Skip to content

Installing on Termux failed due to Node version #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AbdullahBinJahed opened this issue Sep 23, 2021 · 8 comments · Fixed by #4230
Closed

Installing on Termux failed due to Node version #4225

AbdullahBinJahed opened this issue Sep 23, 2021 · 8 comments · Fixed by #4230
Labels
bug Something isn't working

Comments

@AbdullahBinJahed
Copy link
Contributor

OS/Web Information

Application version:
0.117
Packages CPU architecture:
arm
Subscribed repositories:

sources.list

deb https://grimler.se/termux-packages-24/ stable main

science-repo (sources.list.d/science.list)

deb https://packages.termux.org/apt/termux-science science stable

x11-repo (sources.list.d/x11.list)

deb https://packages.termux.org/apt/termux-x11 x11 main

sources.list.d/pointless.list

deb https://its-pointless.github.io/files/24 termux extras

game-repo (sources.list.d/game.list)

deb https://packages.termux.org/apt/termux-games games stable
Updatable packages:
All packages up to date
Android version:
9
Kernel build information:
Linux localhost 4.9.117+ #1 SMP PREEMPT Wed May 27 17:13:44 WIB 2020 armv7l Android
Device manufacturer:
Xiaomi
Device model:
Redmi 6

Steps to Reproduce

  1. yarn global add code-server

Expected

it should work

Actual

Screenshot_2021-09-23-13-05-47-327_com termux

Logs

Screenshot

also tried with npm ...
Screenshot_2021-09-23-13-08-26-320_com termux

Notes

This issue can be reproduced in VS Code: Yes/No

@etienne-85
Copy link

Same issue here.
Nodejs version installed with termux is 16 but code-server expects 14...
Tried also with --ignore-engines flag set in yarn but doesn't help much..

@AbdullahBinJahed
Copy link
Contributor Author

Same issue here.
Nodejs version installed with termux is 16 but code-server expects 14...
Tried also with --ignore-engines flag set in yarn but doesn't help much..

i uninstalled nodejs and installed nodejs-lts by pkg i nodejs-lts which is node 14 ... then yarn command worked and it did installed but can't download any extension on it

@jsjoeio jsjoeio added the needs-investigation This issue needs to be further investigated label Sep 23, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 23, 2021

Hmm...I think this is because we use = 14 in our package.json

https://github.com/cdr/code-server/blob/main/package.json#L121-L122

@TeffenEllis should we change this to >= 14?

@jsjoeio jsjoeio added bug Something isn't working and removed needs-investigation This issue needs to be further investigated labels Sep 23, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Sep 23, 2021
@Vaitek
Copy link

Vaitek commented Sep 23, 2021

Seems i have the same problem. After installing nodejs-lts and upgrading code-server any attempts to install extensions was finished with "extension because it is not compatible with the current version of VS Code (version 1.60.0)." message...

@AbdullahBinJahed
Copy link
Contributor Author

Seems i have the same problem. After installing nodejs-lts and upgrading code-server any attempts to install extensions was finished with "extension because it is not compatible with the current version of VS Code (version 1.60.0)." message...

same problem here ...
btw ... something related ...
https://github.com/vhqtvn/VHEditor-Android

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 23, 2021

After installing nodejs-lts and upgrading code-server any attempts to install extensions was finished with "extension because it is not compatible with the current version of VS Code (version 1.60.0)." message...

I think that's a different problem unfortunately. We need to investigate that further as well.

@jawnsy
Copy link
Contributor

jawnsy commented Sep 28, 2021

@Vaitek @AbdullahBinJahed I'm curious why you are installing from source, rather than using our install.sh script -- can you provide any details on that?

The binary builds include the version of Node.js that we build and test with, which should be a more seamless experience than building from source, especially with a version of Node.js (16) that we do not currently test with. Is it because of a processor architecture difference; are we missing builds to make things more compatible?

i uninstalled nodejs and installed nodejs-lts by pkg i nodejs-lts which is node 14 ... then yarn command worked and it did installed but can't download any extension on it

I think if you can use Node 14 (whether via nodejs-lts or from Nodesource), then that's a better solution, and we can (as a separate issue) help you debug the extension issue.

@AbdullahBinJahed
Copy link
Contributor Author

AbdullahBinJahed commented Sep 28, 2021

@Vaitek @AbdullahBinJahed I'm curious why you are installing from source, rather than using our install.sh script -- can you provide any details on that?

The binary builds include the version of Node.js that we build and test with, which should be a more seamless experience than building from source, especially with a version of Node.js (16) that we do not currently test with. Is it because of a processor architecture difference; are we missing builds to make things more compatible?

i uninstalled nodejs and installed nodejs-lts by pkg i nodejs-lts which is node 14 ... then yarn command worked and it did installed but can't download any extension on it

I think if you can use Node 14 (whether via nodejs-lts or from Nodesource), then that's a better solution, and we can (as a separate issue) help you debug the extension issue.

uhhh... what ? I didn't got most of it ...
installing from source ? I just typed yarn global install code-server .
what install.sh script ? i didn't even git clone it . Processor arch type ? well i'm using a armv7l 32 bit Android phone.

With node-lts it code-server does install but installing extensions doesn't work .. It just says code-server is old version and newer version is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants