Skip to content

markdown preview is not working #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XiepengLi opened this issue Sep 4, 2021 · 8 comments
Closed

markdown preview is not working #4101

XiepengLi opened this issue Sep 4, 2021 · 8 comments
Milestone

Comments

@XiepengLi
Copy link

/webview/main.js:115 Uncaught (in promise) Error: Service Workers are not enabled in browser. Webviews will not work.
/webview/main.js:115 Uncaught (in promise) TypeError: Cannot read property 'addEventListener' of undefined
@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 7, 2021

Possibly related to #3826

@jsjoeio jsjoeio changed the title markdown preview is not work markdown preview is not working Sep 7, 2021
@jsjoeio jsjoeio added the needs-investigation This issue needs to be further investigated label Sep 7, 2021
@jsjoeio jsjoeio added this to the On Deck milestone Sep 7, 2021
@ghost
Copy link

ghost commented Sep 11, 2021

If that can help somebody, I noticed that although it doesn't work on Firefox (linux), it works on my Ipad.

@jgsun
Copy link

jgsun commented Sep 13, 2021

Dear all,

do we have any update?

@ghost
Copy link

ghost commented Sep 13, 2021

Hey I think I tracked down the issue somehow. I have code-server behind a Nginx reverse proxy and I needed to add this to my server block:

proxy_set_header Host $host; proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
Now it works perfectly on my tablet and laptop.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 13, 2021

Nice work @spouradrix! I'll see if we can investigate this on our side in the upcoming release.

@jsjoeio jsjoeio modified the milestones: On Deck, 3.12.1 Sep 13, 2021
@joole
Copy link

joole commented Nov 17, 2021

I found 3.10 - the latest version that all has the same problem,
If you use 127.0.0.1 to access code-server page all the webview ok which like tabnine, platformio,eg
If you use real-ip like 192.168.x.x to access code-server page, all the webview is blanked screen

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 17, 2021

@joole I don't think real-ips use https, do they? That means the service workers won't work which explains the blank webviews

@stale
Copy link

stale bot commented May 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label May 16, 2022
@stale stale bot closed this as completed May 21, 2022
@code-asher code-asher removed the needs-investigation This issue needs to be further investigated label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants