Skip to content

Terminal text all black in Chrome only #4090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zonywhoop opened this issue Sep 2, 2021 · 8 comments
Closed

Terminal text all black in Chrome only #4090

zonywhoop opened this issue Sep 2, 2021 · 8 comments

Comments

@zonywhoop
Copy link

OS/Web Information

  • Web Browser: Chrome 92.0.4515.159 and 93.0.4577.63
  • Local OS: MacOS 11.5.2
  • Remote OS: Ubuntu 18.04
  • Remote Architecture: x64
  • code-server --version: 3.11.1 c680aae

Steps to Reproduce

  1. Install and start code-server
  2. Connect via Chrome and start a terminal session

Expected

Terminal output should show all ansi colors correctly.

Actual

All text is black, regardless of color or bold setting. The same output is shown regardless of shell used and regardless of theme being applied.

Logs

No errors or exceptions are logged

Screenshot

Screenshot from Safari 14.1.2
Screen Shot 2021-09-02 at 7 37 33 AM

Screenshot from Chrome 93.0.4577.63
Screen Shot 2021-09-02 at 7 37 41 AM

Notes

This issue can be reproduced in VS Code: No

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 2, 2021

Are you sure this isn't a theme, font or settings issue?

I can't reproduce locally on macOS + Brave

image

@zonywhoop
Copy link
Author

Here are some screenshots from the latest version of Brave (1.29.76) on my machine using different color themes. This only seems to happen on Chromium based browsers. Safari and Firefox render the terminal fine and the rendering issues do not happen anywhere in in the code-server window that I can tell.

Just as an FYI, this is the first time Brave had loaded this site so there are no cached assets being used here.

Default Light + theme
Brave - Light Plus

Material Theme
Brave - Material Theme

Monkai Theme
Brave - Monokai

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 2, 2021

Hmm 🤔 This is very very strange. Have you tried disabling all extensions?

Do you mind posting your settings.json?

@zonywhoop
Copy link
Author

I just tried disabling all extensions (command palette -> Extensions: Disable all installed extensions) and then did a refresh. The outcome was the same. It's definitely very weird.

Here is my settings.json file, very basic.

{
    "sync.gist": "",
    "sync.autoDownload": false,
    "workbench.colorTheme": "Monokai Dimmed",
    "editor.fontFamily": "'JetBrains Mono', 'Source Code Pro', Hack, Monaco, 'Courier New', monospace",
    "editor.tabSize": 2,
    "editor.fontWeight": 400,
    "terminal.integrated.fontFamily": "'Source Code Pro', 'JetBrains Mono', 'Courier New', Courier",
    "editor.fontSize": 14,
    "files.autoSaveDelay": 5000,
    "terminal.integrated.automationShell.linux": "",
    "terminal.integrated.shell.linux": "/bin/bash",
    "terminal.integrated.shellArgs.linux": [
        "-l"
    ],
    "files.autoSave": "off",
    "yaml.format.enable": true,
    "yaml.format.bracketSpacing": true,
    "workbench.editorAssociations": [
        {
            "viewType": "jupyter-notebook",
            "filenamePattern": "*.ipynb"
        }
    ],
    "redhat.telemetry.enabled": false,
    "terminal.integrated.tabs.enabled": false,
    "workbench.iconTheme": "material-icon-theme"
}

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 2, 2021

Bummer!

Can you comment out or remove these lines?

    "workbench.colorTheme": "Monokai Dimmed",
    "editor.fontFamily": "'JetBrains Mono', 'Source Code Pro', Hack, Monaco, 'Courier New', monospace",
    "terminal.integrated.fontFamily": "'Source Code Pro', 'JetBrains Mono', 'Courier New', Courier",

On an unrelated note I think

    "workbench.editorAssociations": [
        {
            "viewType": "jupyter-notebook",
            "filenamePattern": "*.ipynb"
        }
    ],

causes this issue and you may want to use this solution

@zonywhoop
Copy link
Author

Update,
I made the change for workbench.editorAssociations and that did solve my other issue with the Unable to write to Folder Settings notification - so YAY on that!

I also removed all of the above lines regarding theme and fonts and voila the issue was fixed. I then added them back in until it broke again - it was terminal.integrated.fontFamily. I then went through and added the fonts in 1 by 1 and refreshed till it again broke, this time all works until Source Code Pro is added in. I'm not sure what about that font is breaking it on Chrome - and only chrome - but that is the issue. It works fine with JetBrans Mono or any of the other mono spaced fonts.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 3, 2021

Hooray!

I had a feeling it might be the font family. Not sure what the issue is with Source Code Pro 🤔

Since this isn't an issue with code-server itself, do you mind if we close it?

@zonywhoop
Copy link
Author

Yes, that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants