Skip to content

3.11.0 release did not bump Helm chart version #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ssmall opened this issue Jul 16, 2021 · 2 comments · Fixed by #4273
Closed

3.11.0 release did not bump Helm chart version #3794

ssmall opened this issue Jul 16, 2021 · 2 comments · Fixed by #4273
Assignees
@jsjoeio
Labels
bug Something isn't working ci Issues related to ci high-priority This issue needs to be resolved ASAP
Milestone
4.0.0 - pre-release

Comments

@ssmall
Copy link

ssmall commented Jul 16, 2021

It looks like the 3.11.0 release changed the app version but not the chart version. My understanding of Helm chart versioning semantics is that any app version change should also bump the chart version to provide a clean upgrade path for Helm users.
@jsjoeio jsjoeio added bug Something isn't working ci Issues related to ci labels Jul 19, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 19, 2021

@oxy @code-asher any ideas on what happened here?

@jsjoeio jsjoeio added the high-priority This issue needs to be resolved ASAP label Jul 19, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 19, 2021 •
edited
Loading

Correction: I don't think we used to update this when we update the app version but should be easy to fix + automate for the future.

Thank you for bringing this up!

@jsjoeio jsjoeio added this to the 3.12.0 milestone Jul 19, 2021
@jsjoeio jsjoeio self-assigned this Aug 12, 2021
@jsjoeio jsjoeio modified the milestones: 3.12.0, 3.12.1 Sep 9, 2021
@jsjoeio jsjoeio mentioned this issue Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
bug Something isn't working ci Issues related to ci high-priority This issue needs to be resolved ASAP
Projects
None yet
Milestone
4.0.0 - pre-release
Development

Successfully merging a pull request may close this issue.

chore(helm-chart): bump to 1.0.5 coder/code-server
2 participants
@ssmall @jsjoeio