Skip to content

[dev]: update-vscode.sh should checkout package.json and update yarn.lock #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue May 11, 2021 · 2 comments
Closed
Assignees
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented May 11, 2021

I think I mentioned this before but I wonder if we should modify the VS Code PR script to checkout the package.json and yarn.lock, then remove the dependencies we don't want and regenerate the lock.

@code-asher

Relevant code: https://github.com/cdr/code-server/blob/main/ci/dev/update-vscode.sh

@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label May 11, 2021
@jsjoeio jsjoeio added this to the v3.11.0 milestone May 11, 2021
@code-asher
Copy link
Member

We should also automatically move ripgrep to dependencies as part of this: #3383

@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
@code-asher code-asher modified the milestones: v3.10.1, 3.11.0 May 17, 2021
@jsjoeio jsjoeio self-assigned this May 21, 2021
@jsjoeio jsjoeio modified the milestones: 3.10.2, 3.11.0 May 21, 2021
@jsjoeio jsjoeio modified the milestones: 3.11.0, 3.12.0 Jul 19, 2021
@jsjoeio jsjoeio modified the milestones: 3.12.0, On Deck Sep 9, 2021
@stale
Copy link

stale bot commented Mar 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Mar 8, 2022
@stale stale bot closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

2 participants