Skip to content

Proposal: remove default assignees and approvers from Dependabot PRs #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jawnsy opened this issue Mar 16, 2021 · 2 comments · Fixed by #2914
Closed

Proposal: remove default assignees and approvers from Dependabot PRs #2898

jawnsy opened this issue Mar 16, 2021 · 2 comments · Fixed by #2914
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature
Milestone

Comments

@jawnsy
Copy link
Contributor

jawnsy commented Mar 16, 2021

@code-asher seems to have taken a shine to dependabot's PRs ❤️

I propose we remove jawnsy from the assignee/approver field in the Dependabot configuration, or set both to the cdr/code-server-reviewers team instead (I think the reviewer will be set to cdr/code-server-reviewers anyways due to the repository's code owner settings)

Opening this issue to discuss, will open a PR if there's consensus

@code-asher
Copy link
Member

I'm in favor, reduces steps for me since I won't have to unassign you. 😆

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 16, 2021

All those in favor: say "I"!

(I think the reviewer will be set to cdr/code-server-reviewers anyways due to the repository's code owner settings

Yeah I think you're right here too.

SGTM!

@jsjoeio jsjoeio added this to the v3.9.2 milestone Mar 16, 2021
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Mar 16, 2021
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants