-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add slim variant for docker image codercom/code-server #2488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ok will try to explain a little bit problems with the debian package in your layer.... There are two problem here ! First step, get your docker image provided on docker hub : Launch the tool on your docker image by using : ┃ ● Layers ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ │ Current Layer Contents ├───────────────────────────────────── Here's is.... So this arm deb file is a pure 95 MB waste of size on your final docker file because you don't ever install it because you correctly use "--print-architecture" to install the only good one. To resolve this first problem you probably only have to specify a better wildcard when you copy the deb file.... This one should be quite easy to solve Second problem is more difficult to resolve because it probably involves to change your CI pipeline to make the deb file available somewhere on the internet (github is a solution as I do) and make all the get, installation and remove of the deb package in one line.... To save another 95 MB in your final docker image |
Ah thank you for clarifying! That makes perfect sense. I'll take care of that as part of this issue as it's going to be required to make the slim image truly slim :) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days. |
See #2463
See #2461
See #2459
See #4112
cc @jylenhof
The text was updated successfully, but these errors were encountered: