Skip to content

Heartbeat always gets touched even with no active connections when connected from iPad Safari #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nullpo-head opened this issue Sep 4, 2020 · 3 comments
Labels
browser-safari Safari related bug Something isn't working
Milestone

Comments

@nullpo-head
Copy link

nullpo-head commented Sep 4, 2020

The same problem as #1795 is still happening with 3.5.0 only in Safari on iPad.
Even after closing all tabs or even browser, it seems Code-Server recognizes 1 active connection. Because of that, Heartbeat keeps getting touched.

2020-09-04T15:01:35.219Z] trace 2 active connections
[2020-09-04T15:01:35.220Z] trace heartbeat
[2020-09-04T15:02:35.220Z] trace 1 active connection
[2020-09-04T15:02:35.221Z] trace heartbeat
[2020-09-04T15:03:35.221Z] trace 1 active connection
[2020-09-04T15:03:35.221Z] trace heartbeat

I’ve confirmed that this phenomenon doesn’t happen in Chrome on Windows/macOS, nor Safari on macOS. It seems to happen only in Safari on iPad OS.
FYI, this is the log when I connect to a Code-Server instance by desktop browsers.

[2020-09-04T14:56:03.729Z] trace 2 active connections
[2020-09-04T14:56:03.729Z] trace heartbeat
[server] disconnected from client {"proxies":3}
[2020-09-04T14:57:03.731Z] trace 0 active connections
[2020-09-04T14:57:49.490Z] trace heartbeat

BTW, I’ve noticed this problem while I’m testing Out-of-the-Box-CodeServer, which is an easy setup tool of Code-Server. So, you can reproduce the environment by the tool if you need.

  • Web Browser: Safari
  • Local OS: iPad OS 13.6
  • Remote OS: Ubuntu 20.04
  • Remote Architecture: amd64
  • code-server --version: 3.5.0 de41646
@code-asher code-asher added the iPad label Sep 4, 2020
@code-asher code-asher added the browser-safari Safari related label Sep 14, 2020
@nhooyr nhooyr added bug Something isn't working and removed browser-mobile-safari labels Dec 8, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Dec 8, 2020

Bizarre! What does sudo ss -tpn output?

In #2112 @OliverwengFiltered was able to reproduce with chrome on macOS.

@nhooyr nhooyr added the waiting-for-info Waiting for more information from submitter label Dec 8, 2020
@nhooyr nhooyr removed the waiting-for-info Waiting for more information from submitter label Jan 18, 2021
@jsjoeio jsjoeio added this to the Backlog milestone Apr 29, 2021
@ifduyue
Copy link

ifduyue commented Jul 21, 2021

I think this is the same problem described in #2112

@stale
Copy link

stale bot commented Jan 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Jan 17, 2022
@stale stale bot closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-safari Safari related bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants