Skip to content

docs: Add example to demonstrate deployment on k8s along with a helm chart #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhooyr opened this issue Aug 27, 2020 · 5 comments
Closed

docs: Add example to demonstrate deployment on k8s along with a helm chart #2012

nhooyr opened this issue Aug 27, 2020 · 5 comments
Labels
docs Documentation related enhancement Some improvement that isn't a feature

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Aug 27, 2020

This has been a heavily requested feature.

See #914
@nhooyr nhooyr added the feature label Aug 27, 2020
@nhooyr nhooyr changed the title docs: Add example to demonstrate deployment on k8s docs: Add example to demonstrate deployment on k8s along with a helm chart Aug 27, 2020
@nhooyr nhooyr mentioned this issue Aug 27, 2020
Closed
@Matthew-Beckett
Copy link
Contributor

Hi @nhooyr!

I've just reviewed the original Helm chart commit and it needs minimal work to be current best practice, what is the plan for bringing the Helm chart back into the repository after it was removed? Is a new one being created or is the commit being cherry picked?

I am happy to submit an updated Helm chart for this issue if needed.

Thanks,
Matt

@nhooyr
Copy link
Contributor Author

nhooyr commented Sep 1, 2020

I am happy to submit an updated Helm chart for this issue if needed.

Please go for it!

I'm not actively working on this but if you put up a solid PR, we can totally get it in for v3.5.1

@Matthew-Beckett
Copy link
Contributor

@nhooyr would you be against my PR containing a cherry pick of the original merge commit supplemented with updates for Helm 3 compatibility and best practice improvements?

This was referenced Sep 2, 2020
Closed
Merged
@nhooyr
Copy link
Contributor Author

nhooyr commented Sep 4, 2020

No, that sounds great :)

@nhooyr nhooyr added docs Documentation related enhancement Some improvement that isn't a feature and removed feature labels Dec 7, 2020
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 7, 2020

ooo, we took care of this a while back! See the merged PR linked above.

@nhooyr nhooyr closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation related enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhooyr @Matthew-Beckett