Skip to content

Add --enable-proposed-api #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JayDoubleu opened this issue Aug 18, 2020 · 5 comments
Closed

Add --enable-proposed-api #1981

JayDoubleu opened this issue Aug 18, 2020 · 5 comments
Assignees
Milestone

Comments

@JayDoubleu
Copy link

JayDoubleu commented Aug 18, 2020

I'm trying to pass the --enable-proposed-api flag to vscode
I'm using this patch 9fb33dc
I've also added myextension.id to extensionAllowedProposedApi.

Tried executing via below however it doesn't look like that argument is passed to vscode.

code-server --enable-proposed-api myextension.id
code-server --enable-proposed-api=myextension.id

Is there a quick/other way to pass this argument to vscode?

@nhooyr
Copy link
Contributor

nhooyr commented Aug 20, 2020

See #1779

@code-asher
Copy link
Member

code-asher commented Aug 24, 2020

fwiw I suspect #1779 is a different issue since that's for enabling the proposed API in the client/web worker host rather than the server-side host. The error also looks unusual and I think it might be specific to the remote extensions so there might not be anything we can do about it, but I think it's worth a check to make sure it's not a bug on our end.

@code-asher
Copy link
Member

A bit more context, @JayDoubleu got this error after including the changes in #1779. (Correct me if I'm wrong though!)

@code-asher
Copy link
Member

code-asher commented Aug 24, 2020

nvm, I completely misremembered, it's just that the web handles it differently than the local version and has nothing to do with the extension hosts. #1744

Very possible that resolving #1744 via #1779 will fix this then, apologies for the noise. 😊 It's still odd that the error is different but we'll see how it goes.

@nhooyr
Copy link
Contributor

nhooyr commented Aug 31, 2020

@nhooyr nhooyr closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants