Skip to content

Misplaced globalStorageHome #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ben-z opened this issue Apr 24, 2020 · 5 comments
Closed

Misplaced globalStorageHome #1551

ben-z opened this issue Apr 24, 2020 · 5 comments

Comments

@ben-z
Copy link

ben-z commented Apr 24, 2020

A globalStorageHome directory is created in the project root when I use the VSCodeVim extension.

> tree globalStorageHome/
globalStorageHome/
└── vscodevim.vim

The VSCodeVim extension uses context.globalStoragePath to determine storage location. Did code-server misconfigure this location to be in the project root?

@code-asher
Copy link
Member

Ah yeah I think I see the problem. vim runs in the browser and VS Code's worker extension host isn't capable of using the globalStorageHome value provided by the environment service yet, so we'll just have to patch that support in.

@zengming00
Copy link

zengming00 commented Sep 11, 2020

This bug still exists when I deploy Code-Server on Linux and access it on Windows

$ code-server -v
3.5.0 de41646fc402b968ca6d555fdf2da7de9554d28a

@code-asher
Copy link
Member

code-asher commented Sep 11, 2020

I spun up a 3.5.0 Docker image and when I use the vim extension and do something like :w it creates the global storage directory.

It doesn't seem to create it on startup though which is odd; I think it's supposed to do that so we might want to look into that. But it all seems to be working.

Are there any specific errors you're running into?

@zengming00
Copy link

If I access it on windows, the value of 'context.globalStoragePath' will be:
\home\admin\.local\share\code-server\globalStorage\vscodevim.vim
If I access it on linux, the value of 'context.globalStoragePath' will be:
/home/admin/.local/share/code-server/globalStorage/vscodevim.vim

The code-server always runs on linux, so when I access it with a windows browser, the path separator of 'context.globalStoragePath' is wrong

@code-asher
Copy link
Member

Ahh I see! I opened a new issue for this: #2093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants