-
Notifications
You must be signed in to change notification settings - Fork 6k
Ensure telemetry is not sent when telemetry is disabled #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Well, after further thought, it seems it's included in some extensions. Shouldn't these be affected by the "global" telemetry disable flag?
|
@immanuelfodor we'll investigate. But I think we were already passing that since we just proxy VSCode flags. |
I'm not entirely certain if the We were missing the telemetry option in the settings though so I added it. Extensions appear to read that setting so disabling it should stop extensions from sending telemetry. Should have a new release out some time today with that change. |
Thanks for the update, sounds good! I think we can close this issue if you no longer need it open for workflow purposes. |
If you're able to find some time to test the new release once it comes
out and verify that disabling the setting works for you before we close
this that would be fantastic but if not we can go ahead and close it
now, nbd.
|
Well, it seems the issue still exists but in a weirder way. After upgrading to the latest version, the global telemetry option is checked even though the app is started with disable telemetry option. I'm pretty sure this was unchecked before the upgrade. Since I blocked the telemetry domain on the DNS level, it couldn't phone home but still annoying that it doesn't do what it should. version: "3"
services:
code-server:
container_name: code-server
image: codercom/code-server:v2
restart: unless-stopped
ports:
- "8080:8080"
volumes:
- "./settings:/home/coder/.local/share/code-server"
- "./project:/home/coder/project"
environment:
- PASSWORD=hello
command: --allow-http --disable-telemetry --auth=password
dns:
- 192.168.1.2
- 192.168.1.3 |
For another test, I've just unchecked the main telemetry option, did a simple local docker compose down and up, then removed and reinstalled the PHP plugin. The unchecked main telemetry option after the container recreation it's still unchecked (as it should be, it might read the persisted settings JSON), but there is another telemetry DNS log entry as the latest call probably from the plugin. It says its setting is inherited but somehow it's still leaking. And adding the main telemetry option becoming enabled on upgrade in the previous comment is weird. |
Thank you for testing this! I think we might want to modify Does it only make the one request? I think when telemetry is disabled it might still send |
Well, I can't be sure as I don't know the internals on this depth but I've just opened it in a new tab with a PHP file and there is another blocked entry in the DNS log. |
OK, thanks for the report. 👍 I'll check it out and see if I can figure out what's going on. |
Description
Why is code-server (v2 latest Docker) trying to access
dc.services.visualstudio.com
when telemetry is being disabled? I've found this question online that tells it's application insights. It might not be true anymore but do you know what it's used for? Shouldn't it be disabled by the telemetry disabler flag if it's analytics? As far as I can tell from the DNS logs, it seems to be requested arounddocker-compose up -d
.The text was updated successfully, but these errors were encountered: