Skip to content

Todo tree extension #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortopy opened this issue Oct 9, 2019 · 3 comments
Closed

Todo tree extension #1065

cortopy opened this issue Oct 9, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@cortopy
Copy link

cortopy commented Oct 9, 2019

todo-tree: /bin/sh: 1: /src/build/code-server2.1523-vsc1.38.1-linux-x86_64-built/node_modules/vscode-ripgrep/bin/rg: not found

  • code-server version: 2.1523-vsc1.38.1-linux-x86_64
  • OS Version: Ubuntu
  • Extension: todo tree

Description

When I open vscode I get this error

todo-tree: /bin/sh: 1: /src/build/code-server2.1523-vsc1.38.1-linux-x86_64-built/node_modules/vscode-ripgrep/bin/rg: not found

I've tries to install this dependency in the extension package itself,but it doesn't solve the issue

@sr229 sr229 added the bug Something isn't working label Oct 9, 2019
@code-asher
Copy link
Member

I'm not sure how we're going to solve this one. The extension tries to find ripgrep but it's not going to be there. We can't execute binaries within our binary so we copy it out to /tmp and run it from there.

Setting todo-tree.ripgrep.ripgrep to /tmp/code-server/rg would be a workaround. In a future release we'll be moving it to $XDG_CACHE_DIR/code-server/rg though.

Maybe we could pre-populate this setting or maybe we can do some kind of injection at run time with the correct path somehow.

@patrikzudel
Copy link

patrikzudel commented Dec 1, 2019

As code-asher suggested, the problem was fixed by adding -
"todo-tree.ripgrep.ripgrep": "/tmp/code-server/tg"
to the settings.

After that I had another error when opening the Tree tab which I fixed by creating a "/globalStorage/gruntfuggly.todo-tree" directory where it couldn't find one.

@nhooyr
Copy link
Contributor

nhooyr commented Jan 28, 2020

Will be fixed by #1306

@nhooyr nhooyr closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants