Skip to content

Docker example in README modifies user data as root #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kennylevinsen opened this issue Mar 7, 2019 · 2 comments
Closed

Docker example in README modifies user data as root #102

kennylevinsen opened this issue Mar 7, 2019 · 2 comments

Comments

@kennylevinsen
Copy link

kennylevinsen commented Mar 7, 2019

The README contains the following docker command:

docker run -p 127.0.0.1:8443:8443 -v "${PWD}:/root/project" codercom/code-server code-server --allow-http --no-auth

The result of running this docker command is that code-server accesses the current working directory as root, rather than the current user. This is almost certainly not what the user intended.

For this use-case (simply editing the user's workspace), the --user option should be used to execute code-server as non-root. However, code-server borks out for various reasons if you try that. The workspace folder, for example, is not world-editable. Those issues should be sorted out, and the Docker example in the README should be updated.

@Omeryl
Copy link
Contributor

Omeryl commented Mar 7, 2019

There's currently discussion in #65 trying to figure out the best way to go about this.

@kylecarbs
Copy link
Member

Closing in favor of the larger discussion in #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants