Skip to content

Cleanup systemd unit file #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhooyr opened this issue Sep 20, 2019 · 2 comments
Closed

Cleanup systemd unit file #1010

nhooyr opened this issue Sep 20, 2019 · 2 comments
Assignees
@sr229

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Sep 20, 2019

  • Remove all the extra newlines
  • And why do we need /sbin/start-stop-daemon
  • Remove User=1000? If they're running the binary and not the container, they don't need to be running as UID 1000, they can chose whatever they want.
  • Also don't need service=simple, it's default.
  • Restart should be always
  • Working directory should be just $HOME
@sr229
Copy link
Contributor

sr229 commented Sep 20, 2019

This was a original copy from one of my systemd units, so the plan right now when we closed GH-379 was to fix it some more then PR it in

@nhooyr
Copy link
Contributor Author

nhooyr commented Sep 20, 2019

Mhmm. Lets clean it up in #1012

@sr229 sr229 mentioned this issue Jan 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sr229 sr229

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nhooyr @sr229 @code-asher