Exit with 1 when VS Code CLI errors

code-asher · code-asher · commit fdb46d3fe580 · 2024-01-11T12:46:09.000-09:00
Addresses part of #6367. The script bundled with VS Code still has the same problem but it would be better to fix that one upstream.
diff --git a/src/node/main.ts b/src/node/main.ts
@@ -54,6 +54,7 @@ export const runCodeCli = async (args: DefaultedArgs): Promise<void> => {
     await spawnCli(await toCodeArgs(args))
   } catch (error: any) {
     logger.error("Got error from Code", error)
+    process.exit(1)
   }
 
   process.exit(0)

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ export const runCodeCli = async (args: DefaultedArgs): Promise<void> => {`
`54`	`54`	`await spawnCli(await toCodeArgs(args))`
`55`	`55`	`} catch (error: any) {`
`56`	`56`	`logger.error("Got error from Code", error)`
	`57`	`+ process.exit(1)`
`57`	`58`	`}`
`58`	`59`
`59`	`60`	`process.exit(0)`