Skip to content

Commit fc894e4

Browse files
committed
docs(maintaining): add pull requests section
1 parent d2337bc commit fc894e4

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ VS Code v1.56
6868
### Documentation
6969

7070
- docs(install): add raspberry pi section #3376 @jsjoeio
71+
- docs(maintaining): add pull requests section #3378 @jsjoeio
7172

7273
### Development
7374

docs/MAINTAINING.md

+7
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
- [Triage](#triage)
99
- [Project Boards](#project-boards)
1010
- [Versioning](#versioning)
11+
- [Pull Requests](#pull-requests)
1112

1213
<!-- END doctoc generated TOC please keep comment here to allow auto update -->
1314

@@ -63,3 +64,9 @@ It also gives us a way to separate the issue triage from bigger-picture, long-te
6364
`<major.minor.patch>`
6465

6566
The code-server project follows traditional [semantic versioning](ttps://semver.org/), with the objective of minimizing major changes that break backward compatibility. We increment the patch level for all releases, except when the upstream Visual Studio Code project increments its minor version or we change the plugin API in a backward-compatible manner. In those cases, we increment the minor version rather than the patch level.
67+
68+
## Pull Requests
69+
70+
Ideally, every PR should fix an issue. If it doesn't, make sure it's associated with a version milestone.
71+
72+
If a PR does fix an issue, don't add it to the version milestone. Otherwise, the version milestone will have duplicate information: the issue & the PR fixing the issue.

0 commit comments

Comments
 (0)