Skip to content

Commit deaa224

Browse files
committed
feat: add npm_config_build_from_source to build scripts
This is necessary due to argon2 being added and an upstream issue where it uses a Linux build that is too new for CentOS 7.
1 parent 8c2bb61 commit deaa224

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

ci/build/build-standalone-release.sh

+4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
#!/usr/bin/env bash
22
set -euo pipefail
33

4+
# This is due to an upstream issue with RHEL7/CentOS 7 comptability with node-argon2
5+
# See: https://github.com/cdr/code-server/pull/3422#pullrequestreview-677765057
6+
npm_config_build_from_source=true
7+
48
main() {
59
cd "$(dirname "${0}")/../.."
610
source ./ci/lib.sh

ci/build/npm-postinstall.sh

+3
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ detect_arch() {
1818
}
1919

2020
ARCH="${NPM_CONFIG_ARCH:-$(detect_arch)}"
21+
# This is due to an upstream issue with RHEL7/CentOS 7 comptability with node-argon2
22+
# See: https://github.com/cdr/code-server/pull/3422#pullrequestreview-677765057
23+
npm_config_build_from_source=true
2124

2225
main() {
2326
# Grabs the major version of node from $npm_config_user_agent which looks like

0 commit comments

Comments
 (0)