Skip to content

Commit dcc9cf3

Browse files
authored
Avoid npx for Playwright dependencies (#4437)
It was causing version mismatch errors. It might make more sense to have this in the postinstall but for now I have foregone that as it would be installed in every step including those that do not run e2e tests.
1 parent 13404df commit dcc9cf3

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

.github/workflows/ci.yaml

+2-11
Original file line numberDiff line numberDiff line change
@@ -378,9 +378,6 @@ jobs:
378378
with:
379379
node-version: "14"
380380

381-
- name: Install playwright OS dependencies
382-
run: npx playwright install-deps
383-
384381
- name: Fetch dependencies from cache
385382
id: cache-yarn
386383
uses: actions/cache@v2
@@ -406,14 +403,8 @@ jobs:
406403
if: steps.cache-yarn.outputs.cache-hit != 'true'
407404
run: yarn --frozen-lockfile
408405

409-
# HACK: this shouldn't need to exist, but put it here anyway
410-
# in an attempt to solve Playwright cache failures.
411-
- name: Reinstall playwright
412-
if: steps.cache-yarn.outputs.cache-hit == 'true'
413-
run: |
414-
cd test/
415-
rm -r node_modules/playwright
416-
yarn install --check-files
406+
- name: Install Playwright OS dependencies
407+
run: ./test/node_modules/.bin/playwright install-deps
417408

418409
- name: Run end-to-end tests
419410
run: yarn test:e2e

0 commit comments

Comments
 (0)