Make npm-postinstall.sh more robust

Author: nhooyr

ci/build/npm-postinstall.sh

@@ -4,18 +4,30 @@ set -eu
 main() {
   cd lib/vscode
 
+  if ! echo "$npm_config_user_agent" | grep yarn; then
+    # We are using npm.
+    if [ "${npm_config_unsafe_perm-}" != "true" ]; then
+      echo "Please pass --unsafe-perm to npm to install code-server"
+      echo "Otherwise the postinstall script does not have permissions to run"
+      echo "See https://docs.npmjs.com/misc/config#unsafe-perm"
+      echo "See https://stackoverflow.com/questions/49084929/npm-sudo-global-installation-unsafe-perm"
+      exit 1
+    fi
+  fi
+
   # We have to rename node_modules.bundled to node_modules.
   # The bundled modules were renamed originally to avoid being ignored by yarn.
-  local node_modules
   node_modules="$(find . -depth -name "node_modules.bundled")"
-  local nm
   for nm in $node_modules; do
     rm -Rf "${nm%.bundled}"
     mv "$nm" "${nm%.bundled}"
   done
 
   # Rebuilds native modules.
-  npm rebuild
+  # We use `env -i` to reset the environment.
+  # npm_config_global can make npm rebuild return instantly.
+  # There may be more so we just do a blanket reset.
+  env -i "$SHELL" -lc 'npm rebuild --verbose'
 }
 
 main "$@"

package.json

@@ -1,7 +1,7 @@
 {
   "name": "code-server",
   "license": "MIT",
-  "version": "3.3.0-rc.21",
+  "version": "3.3.0-rc.23",
   "description": "Run VS Code on a remote server.",
   "homepage": "https://github.com/cdr/code-server",
   "bugs": {