Skip to content

Commit d216dc5

Browse files
committed
Fix code-server version not appearing in other languages
It needs to be separate from the localize call since the language version of that string is used and it will not include a spot for the code-server version. I also moved the "v" so we do not get "vUnknown".
1 parent d796cc2 commit d216dc5

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

patches/integration.diff

+8-4
Original file line numberDiff line numberDiff line change
@@ -104,18 +104,22 @@ Index: code-server/lib/vscode/src/vs/workbench/browser/parts/dialogs/dialogHandl
104104
===================================================================
105105
--- code-server.orig/lib/vscode/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
106106
+++ code-server/lib/vscode/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
107-
@@ -144,11 +144,12 @@ export class BrowserDialogHandler implem
107+
@@ -143,12 +143,15 @@ export class BrowserDialogHandler implem
108+
108109
async about(): Promise<void> {
109110
const detailString = (useAgo: boolean): string => {
110-
return localize('aboutDetail',
111+
- return localize('aboutDetail',
111112
- "Version: {0}\nCommit: {1}\nDate: {2}\nBrowser: {3}",
112-
+ "code-server: v{4}\nCode: {0}\nCommit: {1}\nDate: {2}\nBrowser: {3}",
113+
+ return localize('aboutCodeServerDetail',
114+
+ "code-server: {0}",
115+
+ this.productService.codeServerVersion ? `v${this.productService.codeServerVersion}` : 'Unknown'
116+
+ ) + '\n' + localize('aboutDetail',
117+
+ "Code: {0}\nCommit: {1}\nDate: {2}\nBrowser: {3}",
113118
this.productService.version || 'Unknown',
114119
this.productService.commit || 'Unknown',
115120
this.productService.date ? `${this.productService.date}${useAgo ? ' (' + fromNow(new Date(this.productService.date), true) + ')' : ''}` : 'Unknown',
116121
- navigator.userAgent
117122
+ navigator.userAgent,
118-
+ this.productService.codeServerVersion || 'Unknown'
119123
);
120124
};
121125

0 commit comments

Comments
 (0)