Skip to content

Commit cee0ac2

Browse files
committed
Fix error activating extensions on insecure domains
Doesn't affect Firefox but it does affect other browsers. Fixes #1136.
1 parent 780a673 commit cee0ac2

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

scripts/vscode.patch

+15
Original file line numberDiff line numberDiff line change
@@ -812,6 +812,21 @@ index 3bdfa1a79f..ded21cf9c6 100644
812812

813813
// register services that only throw errors
814814
function NotImplementedProxy<T>(name: ServiceIdentifier<T>): { new(): T } {
815+
diff --git a/src/vs/workbench/services/extensions/worker/extensionHostWorker.ts b/src/vs/workbench/services/extensions/worker/extensionHostWorker.ts
816+
index 3b5706ce76..f390ed35dc 100644
817+
--- a/src/vs/workbench/services/extensions/worker/extensionHostWorker.ts
818+
+++ b/src/vs/workbench/services/extensions/worker/extensionHostWorker.ts
819+
@@ -36,7 +36,9 @@ const nativeAddEventLister = addEventListener.bind(self);
820+
self.addEventLister = () => console.trace(`'addEventListener' has been blocked`);
821+
822+
self.indexedDB.open = () => console.trace(`'indexedDB.open' has been blocked`);
823+
-self.caches.open = () => console.trace(`'indexedDB.caches' has been blocked`);
824+
+if (self.caches) { // NOTE@coder: on insecure domains this exists in Firefox but not Chromium or Safari.
825+
+ self.caches.open = () => console.trace(`'indexedDB.caches' has been blocked`);
826+
+}
827+
828+
//#endregion ---
829+
815830
diff --git a/src/vs/workbench/services/localizations/electron-browser/localizationsService.ts b/src/vs/workbench/services/localizations/electron-browser/localizationsService.ts
816831
index 99394090da..4891e0fece 100644
817832
--- a/src/vs/workbench/services/localizations/electron-browser/localizationsService.ts

0 commit comments

Comments
 (0)