Skip to content

Commit cbc2e8b

Browse files
author
Akash Satheesan
authored
chore(ci): remove images and update publish flow (#3147)
* chore(ci): remove unmaintained images * chore(ci): update publish workflow
1 parent 006438d commit cbc2e8b

File tree

4 files changed

+18
-101
lines changed

4 files changed

+18
-101
lines changed

.github/workflows/publish.yaml

+10-8
Original file line numberDiff line numberDiff line change
@@ -9,26 +9,28 @@ on:
99
types: [published]
1010

1111
jobs:
12+
# NOTE: this job requires curl, jq and yarn
13+
# All of them are included in ubuntu-latest.
1214
npm:
1315
runs-on: ubuntu-latest
1416
steps:
15-
- uses: actions/checkout@v1
17+
- uses: actions/checkout@v2
18+
1619
- name: Run ./ci/steps/publish-npm.sh
17-
uses: ./ci/images/debian10
18-
with:
19-
args: ./ci/steps/publish-npm.sh
20+
run: ./ci/steps/publish-npm.sh
2021
env:
2122
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2223
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
2324

25+
# NOTE: this job requires curl, jq and docker
26+
# All of them are included in ubuntu-latest.
2427
docker:
2528
runs-on: ubuntu-latest
2629
steps:
27-
- uses: actions/checkout@v1
30+
- uses: actions/checkout@v2
31+
2832
- name: Run ./ci/steps/push-docker-manifest.sh
29-
uses: ./ci/images/debian10
30-
with:
31-
args: ./ci/steps/push-docker-manifest.sh
33+
run: ./ci/steps/push-docker-manifest.sh
3234
env:
3335
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3436
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}

ci/dev/image/run.sh

-31
This file was deleted.

ci/images/centos7/Dockerfile

-30
This file was deleted.

docs/CONTRIBUTING.md

+8-32
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,6 @@ yarn watch
5757
# Visit http://localhost:8080 once the build is completed.
5858
```
5959

60-
To develop inside an isolated Docker container:
61-
62-
```shell
63-
./ci/dev/image/run.sh yarn
64-
./ci/dev/image/run.sh yarn watch
65-
```
66-
6760
`yarn watch` will live reload changes to the source.
6861

6962
### Updating VS Code
@@ -89,7 +82,9 @@ To update VS Code, follow these steps:
8982
You can build using:
9083

9184
```shell
92-
./ci/dev/image/run.sh ./ci/steps/release.sh
85+
yarn build
86+
yarn build:vscode
87+
yarn release
9388
```
9489

9590
Run your build with:
@@ -101,37 +96,18 @@ yarn --production
10196
node .
10297
```
10398

104-
Build the release packages (make sure that you run `./ci/steps/release.sh` first):
105-
106-
```shell
107-
IMAGE=centos7 ./ci/dev/image/run.sh ./ci/steps/release-packages.sh
108-
# The standalone release is in ./release-standalone
109-
# .deb, .rpm and the standalone archive are in ./release-packages
110-
```
111-
112-
The `release.sh` script is equal to running:
113-
114-
```shell
115-
yarn
116-
yarn build
117-
yarn build:vscode
118-
yarn release
119-
```
120-
121-
And `release-packages.sh` is equal to:
99+
Build the release packages (make sure that you run `yarn release` first):
122100

123101
```shell
124102
yarn release:standalone
125103
yarn test:standalone-release
126104
yarn package
127105
```
128106

129-
For a faster release build, you can run instead:
130-
131-
```shell
132-
KEEP_MODULES=1 ./ci/steps/release.sh
133-
node ./release
134-
```
107+
NOTE: On Linux, the currently running distro will become the minimum supported version.
108+
In our GitHub Actions CI, we use CentOS 7 for maximum compatibility.
109+
If you need your builds to support older distros, run the build commands
110+
inside a Docker container with all the build requirements installed.
135111

136112
## Structure
137113

0 commit comments

Comments
 (0)