Skip to content

Commit c35bf13

Browse files
authored
chore: provide details when update.checked tests fail (#5115)
Using the toBe* functions will let us know what the actual values are rather than just telling us true does not equal false.
1 parent 7780a13 commit c35bf13

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

test/unit/node/update.test.ts

+7-4
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ describe("update", () => {
145145

146146
await expect(settings().read()).resolves.toEqual({ update })
147147
expect(isNaN(update.checked)).toStrictEqual(false)
148-
expect(update.checked < now).toBe(true)
148+
expect(update.checked).toBeLessThan(now)
149149
expect(update.version).toStrictEqual("2.1.0")
150150
expect(spy).toEqual([])
151151
})
@@ -159,7 +159,8 @@ describe("update", () => {
159159

160160
await expect(settings().read()).resolves.toEqual({ update })
161161
expect(isNaN(update.checked)).toStrictEqual(false)
162-
expect(update.checked < Date.now() && update.checked >= now).toStrictEqual(true)
162+
expect(update.checked).toBeGreaterThanOrEqual(now)
163+
expect(update.checked).toBeLessThan(Date.now())
163164
expect(update.version).toStrictEqual("4.1.1")
164165
expect(spy).toStrictEqual(["/latest"])
165166
})
@@ -204,14 +205,16 @@ describe("update", () => {
204205
let now = Date.now()
205206
let update = await provider.getUpdate(true)
206207
expect(isNaN(update.checked)).toStrictEqual(false)
207-
expect(update.checked < Date.now() && update.checked >= now).toEqual(true)
208+
expect(update.checked).toBeGreaterThanOrEqual(now)
209+
expect(update.checked).toBeLessThan(Date.now())
208210
expect(update.version).toStrictEqual("unknown")
209211

210212
provider = new UpdateProvider("http://probably.invalid.dev.localhost/latest", settings())
211213
now = Date.now()
212214
update = await provider.getUpdate(true)
213215
expect(isNaN(update.checked)).toStrictEqual(false)
214-
expect(update.checked < Date.now() && update.checked >= now).toEqual(true)
216+
expect(update.checked).toBeGreaterThanOrEqual(now)
217+
expect(update.checked).toBeLessThan(Date.now())
215218
expect(update.version).toStrictEqual("unknown")
216219
})
217220

0 commit comments

Comments
 (0)