Skip to content

Commit bd43ca4

Browse files
committed
helm: Fix README examples
Not sure where --name came from? Maybe an older version of helm. Ah, it's from v2.16.7
1 parent 52ea32f commit bd43ca4

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

ci/helm-chart/README.md

+11-10
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ This chart is community maintained by [@Matthew-Beckett](https://github.com/Matt
1010
## TL;DR;
1111

1212
```console
13-
$ git clone https://github.com/cdr/code-server.git
14-
$ helm install code-server charts/code-server
13+
$ git clone https://github.com/cdr/code-server
14+
$ helm install code-server code-server/ci/helm-chart
1515
```
1616

1717
## Introduction
@@ -26,10 +26,11 @@ package manager.
2626

2727
## Installing the Chart
2828

29-
To install the chart with the release name `my-release`:
29+
To install the chart with the release name `code-server`:
3030

3131
```console
32-
$ helm install --name my-release charts/code-server
32+
$ git clone https://github.com/cdr/code-server
33+
$ helm install code-server code-server/ci/helm-chart
3334
```
3435

3536
The command deploys code-server on the Kubernetes cluster in the default
@@ -40,10 +41,10 @@ that can be configured during installation.
4041
4142
## Uninstalling the Chart
4243

43-
To uninstall/delete the `my-release` deployment:
44+
To uninstall/delete the `code-server` deployment:
4445

4546
```console
46-
$ helm delete my-release
47+
$ helm delete code-server
4748
```
4849

4950
The command removes all the Kubernetes components associated with the chart and
@@ -97,9 +98,9 @@ Specify each parameter using the `--set key=value[,key=value]` argument to `helm
9798
install`. For example,
9899

99100
```console
100-
$ helm install --name my-release \
101-
--set persistence.enabled=false \
102-
deployment/chart
101+
$ helm install code-server \
102+
deployment/chart \
103+
--set persistence.enabled=false
103104
```
104105

105106
The above command sets the the persistence storage to false.
@@ -108,7 +109,7 @@ Alternatively, a YAML file that specifies the values for the above parameters
108109
can be provided while installing the chart. For example,
109110

110111
```console
111-
$ helm install --name my-release -f values.yaml deployment/chart
112+
$ helm install code-server deployment/chart -f values.yaml
112113
```
113114

114115
> **Tip**: You can use the default [values.yaml](values.yaml)

ci/helm-chart/values.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ persistence:
112112
##
113113
# storageClass: "-"
114114
accessMode: ReadWriteOnce
115-
size: 1Gi
115+
size: 10Gi
116116
annotations: {}
117117
# existingClaim: ""
118118
# hostPath: /data

0 commit comments

Comments
 (0)