Skip to content

Commit bd2e55d

Browse files
committed
Make README more clear
1 parent 59694fb commit bd2e55d

File tree

5 files changed

+12
-11
lines changed

5 files changed

+12
-11
lines changed

README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ Run [VS Code](https://github.com/Microsoft/vscode) on any machine anywhere and a
1818

1919
For a full setup and walkthrough, please see [./doc/guide.md](./doc/guide.md).
2020

21+
### Quick Install
22+
2123
We have a [script](./install.sh) to install code-server for Linux and macOS.
2224

2325
It tries to use the system package manager if possible.
@@ -36,14 +38,10 @@ curl -fsSL https://code-server.dev/install.sh | sh
3638

3739
The install script will print out how to run and start using code-server.
3840

39-
If you believe an install script used with `curl | sh` is insecure, please give
40-
[this wonderful blogpost](https://sandstorm.io/news/2015-09-24-is-curl-bash-insecure-pgp-verified-install) by
41-
[sandstorm.io](https://sandstorm.io) a read.
41+
### Manual Install
4242

4343
Docs on the install script, manual installation and docker image are at [./doc/install.md](./doc/install.md).
4444

45-
We also highly recommend reading the [FAQ](./doc/FAQ.md) on the [Differences compared to VS Code](./doc/FAQ.md#differences-compared-to-vs-code).
46-
4745
## FAQ
4846

4947
See [./doc/FAQ.md](./doc/FAQ.md).

ci/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,11 @@ Make sure you have `$GITHUB_TOKEN` set and [hub](https://github.com/github/hub)
2222
the updated version.
2323
1. Summarize the major changes in the release notes and link to the relevant issues.
2424
4. Wait for the artifacts in step 2 to build.
25-
5. Run `yarn release:github-assets` to download the `release-packages` artifact and then
25+
5. Run `yarn release:github-assets` to download the `release-packages` artifact and
2626
upload them to the draft release.
2727
6. Run some basic sanity tests on one of the released packages.
28-
7. Make sure the github release tag is the commit with the artifacts.
28+
7. Make sure the github release tag is the commit with the artifacts. This is a bug in
29+
`hub` where uploading assets in step 5 will break the tag.
2930
8. Publish the release and merge the PR.
3031
1. CI will automatically grab the artifacts and then:
3132
1. Publish the NPM package from `npm-package`.

ci/build/release-github-assets.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ main() {
1111
source ./ci/lib.sh
1212

1313
download_artifact release-packages ./release-packages
14-
local assets=(./release-packages/code-server*"$VERSION"*{.tar.gz,.deb,.rpm})
14+
local assets=(./release-packages/code-server*"$VERSION"*{.tar.gz,.zip,.deb,.rpm})
1515
for i in "${!assets[@]}"; do
1616
assets[$i]="--attach=${assets[$i]}"
1717
done

doc/guide.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ Further docs are at:
2525
- [FAQ](./FAQ.md) for common questions.
2626
- [CONTRIBUTING](../doc/CONTRIBUTING.md) for development docs
2727

28+
We highly recommend reading the [FAQ](./doc/FAQ.md) on the [Differences compared to VS Code](./doc/FAQ.md#differences-compared-to-vs-code) before beginning.
29+
2830
We'll walk you through acquiring a remote machine to run `code-server` on
2931
and then exposing `code-server` so you can securely access it.
3032

doc/install.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
- [install.sh](#installsh)
66
- [Flags](#flags)
7-
- [Detect Reference](#detect-reference)
7+
- [Detection Reference](#detection-reference)
88
- [Debian, Ubuntu](#debian-ubuntu)
99
- [Fedora, CentOS, RHEL, SUSE](#fedora-centos-rhel-suse)
1010
- [Arch Linux](#arch-linux)
@@ -42,7 +42,7 @@ If you believe an install script used with `curl | sh` is insecure, please give
4242
[this wonderful blogpost](https://sandstorm.io/news/2015-09-24-is-curl-bash-insecure-pgp-verified-install) by
4343
[sandstorm.io](https://sandstorm.io) a read.
4444

45-
If you'd still prefer manual installation despite the below [detect reference](#detect-reference) and `--dry-run`
45+
If you'd still prefer manual installation despite the below [detection reference](#detection-reference) and `--dry-run`
4646
then continue on for docs on manual installation. The [`install.sh`](../install.sh) script runs the _exact_ same
4747
commands presented in the rest of this document.
4848

@@ -56,7 +56,7 @@ commands presented in the rest of this document.
5656
- `--version=X.X.X` to install version `X.X.X` instead of latest.
5757
- `--help` to see full usage docs.
5858

59-
### Detect Reference
59+
### Detection Reference
6060

6161
- For Debian, Ubuntu and Raspbian it will install the latest deb package.
6262
- For Fedora, CentOS, RHEL and openSUSE it will install the latest rpm package.

0 commit comments

Comments
 (0)