Skip to content

Commit b5af426

Browse files
authored
Properly dispose everything in tunnel view cells (#118546)
Fixes #118544
1 parent f299ec0 commit b5af426

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/vs/workbench/contrib/remote/browser/tunnelView.ts

+7
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,7 @@ class ActionBarRenderer extends Disposable implements ITableRenderer<ActionBarCe
359359
templateData.button.element.style.display = 'none';
360360
templateData.button.dispose();
361361
}
362+
templateData.elementDisposable.dispose();
362363

363364
let editableData: IEditableData | undefined;
364365
if (element.editId === TunnelEditId.New && (editableData = this.remoteExplorerService.getEditableData(undefined))) {
@@ -481,9 +482,15 @@ class ActionBarRenderer extends Disposable implements ITableRenderer<ActionBarCe
481482
});
482483
}
483484

485+
disposeElement(element: ActionBarCell, index: number, templateData: IActionBarTemplateData, height: number | undefined) {
486+
templateData.elementDisposable.dispose();
487+
}
488+
484489
disposeTemplate(templateData: IActionBarTemplateData): void {
490+
templateData.label.dispose();
485491
templateData.actionBar.dispose();
486492
templateData.elementDisposable.dispose();
493+
templateData.button?.dispose();
487494
}
488495
}
489496

0 commit comments

Comments
 (0)