Skip to content

Commit b49b179

Browse files
authored
Add socket type to websocket connection query (#3391)
This was added a long time ago but accidentally lost when we reverted the retry changes to this file after one of the VS Code updates that added their own retry (we reverted everything not realizing we had other unrelated changes in here).
1 parent 36265dd commit b49b179

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

lib/vscode/src/vs/platform/remote/common/remoteAgentConnection.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,9 @@ async function connectToRemoteExtensionHostAgent(options: ISimpleConnectionOptio
229229

230230
let socket: ISocket;
231231
try {
232-
socket = await createSocket(options.logService, options.socketFactory, options.host, options.port, `reconnectionToken=${options.reconnectionToken}&reconnection=${options.reconnectionProtocol ? 'true' : 'false'}`, timeoutCancellationToken);
232+
// NOTE@coder: Add connection type to the socket. This is so they can be
233+
// distinguished by the backend.
234+
socket = await createSocket(options.logService, options.socketFactory, options.host, options.port, `type=${connectionTypeToString(connectionType)}&reconnectionToken=${options.reconnectionToken}&reconnection=${options.reconnectionProtocol ? 'true' : 'false'}`, timeoutCancellationToken);
233235
} catch (error) {
234236
options.logService.error(`${logPrefix} socketFactory.connect() failed or timed out. Error:`);
235237
options.logService.error(error);

0 commit comments

Comments
 (0)