code review comments

Author: jawnsy

src/node/constants.ts

@@ -17,26 +17,31 @@ export function getPackageJson(relativePath: string): JSONSchemaForNPMPackageJso
 }
 
 const pkg = getPackageJson("../../package.json")
+const codePkg = getPackageJson("../../vendor/modules/code-oss-dev/package.json")
 
 export const pkgName = pkg.name || "code-server"
 export const version = pkg.version || "development"
 export const commit = pkg.commit || "development"
 export const rootPath = path.resolve(__dirname, "../..")
 export const vsRootPath = path.join(rootPath, "vendor/modules/code-oss-dev")
-export const codeVersion = require(path.join(vsRootPath, "package.json")).version || "development"
+export const codeVersion = codePkg.version || "development"
 export const tmpdir = path.join(os.tmpdir(), "code-server")
 export const isDevMode = commit === "development"
 export const httpProxyUri =
   process.env.HTTPS_PROXY || process.env.https_proxy || process.env.HTTP_PROXY || process.env.http_proxy
 
-// getVersionString returns a human-readable version string suitable
-// for outputting to the console.
+/**
+ * getVersionString returns a human-readable version string suitable
+ * for outputting to the console.
+ */
 export function getVersionString(): string {
   return [version, commit].join(" ")
 }
 
-// getVersionJsonString returns a machine-readable version string
-// suitable for outputting to the console.
+/**
+ * getVersionJsonString returns a machine-readable version string
+ * suitable for outputting to the console.
+ */
 export function getVersionJsonString(): string {
   return JSON.stringify({
     codeServer: version,