fixup! remove return true

Author: jsjoeio

src/browser/pages/vscode.ts

@@ -126,10 +126,6 @@ export function registerRequireOnSelf({ self, origin, nlsConfig, options }: Regi
   // Source: https://stackoverflow.com/a/30740935
   type FixMeLater = any
   ;(self.require as FixMeLater) = requireOnSelf
-
-  // If everything worked, then return true
-  // so the caller knows it registered succesfully
-  return true
 }
 
 try {

test/unit/browser/pages/vscode.test.ts

@@ -328,27 +328,5 @@ describe("vscode", () => {
       const hasRequireProperty = Object.prototype.hasOwnProperty.call(mockSelf, "require")
       expect(hasRequireProperty).toBeTruthy()
     })
-    it("should return true if it registered succesfully", () => {
-      const options = {
-        base: "/",
-        csStaticBase: "/",
-        logLevel: 1,
-      }
-      const nlsConfig = {
-        first: "Jane",
-        last: "Doe",
-        locale: "en",
-        availableLanguages: {},
-      }
-      const mockSelf = {} as Window & typeof globalThis
-      const didRegister = registerRequireOnSelf({
-        self: mockSelf,
-        origin: "localthost",
-        nlsConfig: nlsConfig,
-        options,
-      })
-
-      expect(didRegister).toBe(true)
-    })
   })
 })