Skip to content

Commit a8719e1

Browse files
committed
refactor: change config to save all e2e videos
1 parent 1e6f4f2 commit a8719e1

File tree

2 files changed

+1
-29
lines changed

2 files changed

+1
-29
lines changed

test/config.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ setConfig(config)
6464

6565
const options: PlaywrightOptions = {
6666
headless: true, // Run tests in headless browsers.
67-
video: "retry-with-video",
67+
video: "on",
6868
}
6969

7070
// Run tests in three browsers.

test/e2e/login.test.ts

-28
Original file line numberDiff line numberDiff line change
@@ -64,32 +64,4 @@ test.describe("login", () => {
6464
await page.waitForLoadState("networkidle")
6565
expect(await page.isVisible("text=Login rate limited!"))
6666
})
67-
68-
// This test takes 8mins to run and is probably not worth adding to our e2e suite
69-
// test.only("should not count successful logins against the rate limiter", options, async ({ page }) => {
70-
// for (let i = 1; i <= 14; i++) {
71-
// await page.goto(CODE_SERVER_ADDRESS, { waitUntil: "networkidle" })
72-
// await page.fill(".password", PASSWORD)
73-
// await page.click(".submit")
74-
// await page.waitForLoadState("networkidle")
75-
// // Make sure the editor actually loaded
76-
// await page.isVisible("div.monaco-workbench")
77-
78-
// // Delete cookie
79-
// await page.evaluate(() => {
80-
// document.cookie = "key" + "=; Path=/; Expires=Thu, 01 Jan 1970 00:00:01 GMT;"
81-
// return Promise.resolve()
82-
// })
83-
84-
// // Go back to address, which should be the login page
85-
// await page.goto(CODE_SERVER_ADDRESS, { waitUntil: "networkidle" })
86-
// }
87-
88-
// // On the 15th time, we should see the editor
89-
// await page.fill(".password", PASSWORD)
90-
// await page.click(".submit")
91-
// await page.waitForLoadState("networkidle")
92-
// // Make sure the editor actually loaded
93-
// expect(await page.isVisible("div.monaco-workbench"))
94-
// })
9567
})

0 commit comments

Comments
 (0)