Skip to content

Commit a37572d

Browse files
committed
ci: Disable no-unused-vars for function args
See previous commit for failure introduced.
1 parent 40a7c11 commit a37572d

File tree

3 files changed

+52
-44
lines changed

3 files changed

+52
-44
lines changed

.eslintrc.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ extends:
1919
- prettier/@typescript-eslint # Remove conflicts again.
2020

2121
rules:
22+
# Sometimes you need to add args to implement a function signature even
23+
# if they are unused.
24+
"@typescript-eslint/no-unused-vars": ["error", { "args": "none" }]
2225
# For overloads.
2326
no-dupe-class-members: off
2427
"@typescript-eslint/no-use-before-define": off

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747
"@types/tar-fs": "^2.0.0",
4848
"@types/tar-stream": "^2.1.0",
4949
"@types/ws": "^7.2.6",
50-
"@typescript-eslint/eslint-plugin": "^3.10.1",
51-
"@typescript-eslint/parser": "^3.10.1",
50+
"@typescript-eslint/eslint-plugin": "^4.7.0",
51+
"@typescript-eslint/parser": "^4.7.0",
5252
"doctoc": "^1.4.0",
5353
"eslint": "^7.7.0",
5454
"eslint-config-prettier": "^6.0.0",

yarn.lock

+47-42
Original file line numberDiff line numberDiff line change
@@ -1040,11 +1040,6 @@
10401040
resolved "https://registry.yarnpkg.com/@types/cookiejar/-/cookiejar-2.1.2.tgz#66ad9331f63fe8a3d3d9d8c6e3906dd10f6446e8"
10411041
integrity sha512-t73xJJrvdTjXrn4jLS9VSGRbz0nUY3cl2DMGDU48lKl+HR9dbbjW2A9r3g40VA++mQpy6uuHg33gy7du2BKpog==
10421042

1043-
"@types/eslint-visitor-keys@^1.0.0":
1044-
version "1.0.0"
1045-
resolved "https://registry.yarnpkg.com/@types/eslint-visitor-keys/-/eslint-visitor-keys-1.0.0.tgz#1ee30d79544ca84d68d4b3cdb0af4f205663dd2d"
1046-
integrity sha512-OCutwjDZ4aFS6PB1UZ988C4YgwlBHJd6wCeQqaLdmadZ/7e+w79+hbMUFC1QXDNCmdyoRfAFdm0RypzwR+Qpag==
1047-
10481043
"@types/express-serve-static-core@*":
10491044
version "4.17.13"
10501045
resolved "https://registry.yarnpkg.com/@types/express-serve-static-core/-/express-serve-static-core-4.17.13.tgz#d9af025e925fc8b089be37423b8d1eac781be084"
@@ -1219,65 +1214,75 @@
12191214
dependencies:
12201215
"@types/node" "*"
12211216

1222-
"@typescript-eslint/eslint-plugin@^3.10.1":
1223-
version "3.10.1"
1224-
resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-3.10.1.tgz#7e061338a1383f59edc204c605899f93dc2e2c8f"
1225-
integrity sha512-PQg0emRtzZFWq6PxBcdxRH3QIQiyFO3WCVpRL3fgj5oQS3CDs3AeAKfv4DxNhzn8ITdNJGJ4D3Qw8eAJf3lXeQ==
1217+
"@typescript-eslint/eslint-plugin@^4.7.0":
1218+
version "4.7.0"
1219+
resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-4.7.0.tgz#85c9bbda00c0cb604d3c241f7bc7fb171a2d3479"
1220+
integrity sha512-li9aiSVBBd7kU5VlQlT1AqP0uWGDK6JYKUQ9cVDnOg34VNnd9t4jr0Yqc/bKxJr/tDCPDaB4KzoSFN9fgVxe/Q==
12261221
dependencies:
1227-
"@typescript-eslint/experimental-utils" "3.10.1"
1222+
"@typescript-eslint/experimental-utils" "4.7.0"
1223+
"@typescript-eslint/scope-manager" "4.7.0"
12281224
debug "^4.1.1"
12291225
functional-red-black-tree "^1.0.1"
12301226
regexpp "^3.0.0"
12311227
semver "^7.3.2"
12321228
tsutils "^3.17.1"
12331229

1234-
"@typescript-eslint/experimental-utils@3.10.1":
1235-
version "3.10.1"
1236-
resolved "https://registry.yarnpkg.com/@typescript-eslint/experimental-utils/-/experimental-utils-3.10.1.tgz#e179ffc81a80ebcae2ea04e0332f8b251345a686"
1237-
integrity sha512-DewqIgscDzmAfd5nOGe4zm6Bl7PKtMG2Ad0KG8CUZAHlXfAKTF9Ol5PXhiMh39yRL2ChRH1cuuUGOcVyyrhQIw==
1230+
"@typescript-eslint/experimental-utils@4.7.0":
1231+
version "4.7.0"
1232+
resolved "https://registry.yarnpkg.com/@typescript-eslint/experimental-utils/-/experimental-utils-4.7.0.tgz#8d1058c38bec3d3bbd9c898a1c32318d80faf3c5"
1233+
integrity sha512-cymzovXAiD4EF+YoHAB5Oh02MpnXjvyaOb+v+BdpY7lsJXZQN34oIETeUwVT2XfV9rSNpXaIcknDLfupO/tUoA==
12381234
dependencies:
12391235
"@types/json-schema" "^7.0.3"
1240-
"@typescript-eslint/types" "3.10.1"
1241-
"@typescript-eslint/typescript-estree" "3.10.1"
1236+
"@typescript-eslint/scope-manager" "4.7.0"
1237+
"@typescript-eslint/types" "4.7.0"
1238+
"@typescript-eslint/typescript-estree" "4.7.0"
12421239
eslint-scope "^5.0.0"
12431240
eslint-utils "^2.0.0"
12441241

1245-
"@typescript-eslint/parser@^3.10.1":
1246-
version "3.10.1"
1247-
resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-3.10.1.tgz#1883858e83e8b442627e1ac6f408925211155467"
1248-
integrity sha512-Ug1RcWcrJP02hmtaXVS3axPPTTPnZjupqhgj+NnZ6BCkwSImWk/283347+x9wN+lqOdK9Eo3vsyiyDHgsmiEJw==
1242+
"@typescript-eslint/parser@^4.7.0":
1243+
version "4.7.0"
1244+
resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-4.7.0.tgz#44bdab0f788b478178368baa65d3365fdc63da1c"
1245+
integrity sha512-+meGV8bMP1sJHBI2AFq1GeTwofcGiur8LoIr6v+rEmD9knyCqDlrQcFHR0KDDfldHIFDU/enZ53fla6ReF4wRw==
12491246
dependencies:
1250-
"@types/eslint-visitor-keys" "^1.0.0"
1251-
"@typescript-eslint/experimental-utils" "3.10.1"
1252-
"@typescript-eslint/types" "3.10.1"
1253-
"@typescript-eslint/typescript-estree" "3.10.1"
1254-
eslint-visitor-keys "^1.1.0"
1247+
"@typescript-eslint/scope-manager" "4.7.0"
1248+
"@typescript-eslint/types" "4.7.0"
1249+
"@typescript-eslint/typescript-estree" "4.7.0"
1250+
debug "^4.1.1"
12551251

1256-
"@typescript-eslint/[email protected]":
1257-
version "3.10.1"
1258-
resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-3.10.1.tgz#1d7463fa7c32d8a23ab508a803ca2fe26e758727"
1259-
integrity sha512-+3+FCUJIahE9q0lDi1WleYzjCwJs5hIsbugIgnbB+dSCYUxl8L6PwmsyOPFZde2hc1DlTo/xnkOgiTLSyAbHiQ==
1252+
"@typescript-eslint/[email protected]":
1253+
version "4.7.0"
1254+
resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-4.7.0.tgz#2115526085fb72723ccdc1eeae75dec7126220ed"
1255+
integrity sha512-ILITvqwDJYbcDCROj6+Ob0oCKNg3SH46iWcNcTIT9B5aiVssoTYkhKjxOMNzR1F7WSJkik4zmuqve5MdnA0DyA==
1256+
dependencies:
1257+
"@typescript-eslint/types" "4.7.0"
1258+
"@typescript-eslint/visitor-keys" "4.7.0"
12601259

1261-
"@typescript-eslint/[email protected]":
1262-
version "3.10.1"
1263-
resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-3.10.1.tgz#fd0061cc38add4fad45136d654408569f365b853"
1264-
integrity sha512-QbcXOuq6WYvnB3XPsZpIwztBoquEYLXh2MtwVU+kO8jgYCiv4G5xrSP/1wg4tkvrEE+esZVquIPX/dxPlePk1w==
1260+
"@typescript-eslint/[email protected]":
1261+
version "4.7.0"
1262+
resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-4.7.0.tgz#5e95ef5c740f43d942542b35811f87b62fccca69"
1263+
integrity sha512-uLszFe0wExJc+I7q0Z/+BnP7wao/kzX0hB5vJn4LIgrfrMLgnB2UXoReV19lkJQS1a1mHWGGODSxnBx6JQC3Sg==
1264+
1265+
"@typescript-eslint/[email protected]":
1266+
version "4.7.0"
1267+
resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-4.7.0.tgz#539531167f05ba20eb0b6785567076679e29d393"
1268+
integrity sha512-5XZRQznD1MfUmxu1t8/j2Af4OxbA7EFU2rbo0No7meb46eHgGkSieFdfV6omiC/DGIBhH9H9gXn7okBbVOm8jw==
12651269
dependencies:
1266-
"@typescript-eslint/types" "3.10.1"
1267-
"@typescript-eslint/visitor-keys" "3.10.1"
1270+
"@typescript-eslint/types" "4.7.0"
1271+
"@typescript-eslint/visitor-keys" "4.7.0"
12681272
debug "^4.1.1"
1269-
glob "^7.1.6"
1273+
globby "^11.0.1"
12701274
is-glob "^4.0.1"
12711275
lodash "^4.17.15"
12721276
semver "^7.3.2"
12731277
tsutils "^3.17.1"
12741278

1275-
"@typescript-eslint/visitor-keys@3.10.1":
1276-
version "3.10.1"
1277-
resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-3.10.1.tgz#cd4274773e3eb63b2e870ac602274487ecd1e931"
1278-
integrity sha512-9JgC82AaQeglebjZMgYR5wgmfUdUc+EitGUUMW8u2nDckaeimzW+VsoLV6FoimPv2id3VQzfjwBxEMVz08ameQ==
1279+
"@typescript-eslint/visitor-keys@4.7.0":
1280+
version "4.7.0"
1281+
resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-4.7.0.tgz#6783824f22acfc49e754970ed21b88ac03b80e6f"
1282+
integrity sha512-aDJDWuCRsf1lXOtignlfiPODkzSxxop7D0rZ91L6ZuMlcMCSh0YyK+gAfo5zN/ih6WxMwhoXgJWC3cWQdaKC+A==
12791283
dependencies:
1280-
eslint-visitor-keys "^1.1.0"
1284+
"@typescript-eslint/types" "4.7.0"
1285+
eslint-visitor-keys "^2.0.0"
12811286

12821287
abab@^2.0.0:
12831288
version "2.0.5"
@@ -3675,7 +3680,7 @@ glob-to-regexp@^0.3.0:
36753680
resolved "https://registry.yarnpkg.com/glob-to-regexp/-/glob-to-regexp-0.3.0.tgz#8c5a1494d2066c570cc3bfe4496175acc4d502ab"
36763681
integrity sha1-jFoUlNIGbFcMw7/kSWF1rMTVAqs=
36773682

3678-
[email protected], glob@^7.0.0, glob@^7.1.3, glob@^7.1.4, glob@^7.1.6:
3683+
[email protected], glob@^7.0.0, glob@^7.1.3, glob@^7.1.4:
36793684
version "7.1.6"
36803685
resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.6.tgz#141f33b81a7c2492e125594307480c46679278a6"
36813686
integrity sha512-LwaxwyZ72Lk7vZINtNNrywX0ZuLyStrdDtabefZKAY5ZGJhVtgdznluResxNmPitE0SAO+O26sWTHeKSI2wMBA==

0 commit comments

Comments
 (0)