fix: remove upstream command thing

Author: jsjoeio

ci/steps/brew-bump.sh

@@ -38,7 +38,7 @@ main() {
   echo "Changing into homebrew-core directory"
   cd homebrew-core && pwd
 
-  echo "Adding Homebrew/homebrew-core as $(upstream)"
+  echo "Adding Homebrew/homebrew-core"
   git remote add upstream https://github.com/Homebrew/homebrew-core.git
 
   # Make sure the git remote step is successful
@@ -49,18 +49,24 @@ main() {
     exit 1
   fi
 
+  # TODO@jsjoeio - can I somehow check that this succeeded?
   echo "Fetching upstream Homebrew/hombrew-core commits"
   git fetch upstream
 
+  # TODO@jsjoeio - can I somehow check that this succeeded?
   echo "Merging in latest Homebrew/homebrew-core changes"
   git merge upstream/master
 
   echo "Pushing changes to cdrci/homebrew-core fork on GitHub"
   # Source: https://serverfault.com/a/912788
   # shellcheck disable=SC2016,SC2028
   echo '#!/bin/sh\nexec echo "$HOMEBREW_GITHUB_API_TOKEN"' > "$HOME"/.git-askpass.sh
+
+  # TODO@jsjoeio - check that git-askpass.sh was created
   # Ensure it's executable since we just created it
   chmod +x "$HOME/.git-askpass.sh"
+
+  # TODO@jsjoeio - check that git-askpass.sh has executable permissions
   # GIT_ASKPASS lets us use the password when pushing without revealing it in the process list
   # See: https://serverfault.com/a/912788
   GIT_ASKPASS="$HOME/.git-askpass.sh" git push https://[email protected]/cdr-oss/homebrew-core.git --all
@@ -80,6 +86,8 @@ main() {
   # Clean up and remove homebrew-core
   cd ..
   rm -rf homebrew-core
+
+  # TODO@jsjoeio - check that homebrew-core was removed
 }
 
 main "$@"