fix(ci): temporarily disable install deps from cache

Author: jsjoeio

.github/workflows/ci.yaml

@@ -33,14 +33,18 @@ jobs:
       - name: Install helm
         uses: azure/[email protected]
 
-      - name: Fetch dependencies from cache
-        id: cache-yarn
-        uses: actions/cache@v2
-        with:
-          path: "**/node_modules"
-          key: yarn-build-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            yarn-build-
+      # NOTE@jsjoeio
+      # disabling this until we can audit the build process
+      # and the usefulness of this step
+      # See: https://github.com/cdr/code-server/issues/4287
+      # - name: Fetch dependencies from cache
+      #   id: cache-yarn
+      #   uses: actions/cache@v2
+      #   with:
+      #     path: "**/node_modules"
+      #     key: yarn-build-${{ hashFiles('**/yarn.lock') }}
+      #     restore-keys: |
+      #       yarn-build-
 
       - name: Install dependencies
         # if: steps.cache-yarn.outputs.cache-hit != 'true'

src/node/cli.ts

@@ -672,7 +672,7 @@ export const shouldRunVsCodeCli = (args: Args): boolean => {
 /**
  * Reads the socketPath based on path passed in.
  *
- * The one usually pased in is the DEFAULT_SOCKET_PATH.
+ * The one usually passed in is the DEFAULT_SOCKET_PATH.
  *
  * If it can't read the path, it throws an error and returns undefined.
  */