Skip to content

Commit 944f490

Browse files
committed
Install Playwright dependencies as part of postinstall
This also removes npx which was causing issues with mismatched versions.
1 parent 0cbf1ca commit 944f490

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

.github/workflows/ci.yaml

-12
Original file line numberDiff line numberDiff line change
@@ -378,9 +378,6 @@ jobs:
378378
with:
379379
node-version: "14"
380380

381-
- name: Install playwright OS dependencies
382-
run: npx playwright install-deps
383-
384381
- name: Fetch dependencies from cache
385382
id: cache-yarn
386383
uses: actions/cache@v2
@@ -406,15 +403,6 @@ jobs:
406403
if: steps.cache-yarn.outputs.cache-hit != 'true'
407404
run: yarn --frozen-lockfile
408405

409-
# HACK: this shouldn't need to exist, but put it here anyway
410-
# in an attempt to solve Playwright cache failures.
411-
- name: Reinstall playwright
412-
if: steps.cache-yarn.outputs.cache-hit == 'true'
413-
run: |
414-
cd test/
415-
rm -r node_modules/playwright
416-
yarn install --check-files
417-
418406
- name: Run end-to-end tests
419407
run: yarn test:e2e
420408

test/package.json

+3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
{
22
"license": "MIT",
33
"#": "We must put jest in a sub-directory otherwise VS Code somehow picks up the types and generates conflicts with mocha.",
4+
"scripts": {
5+
"postinstall": "./node_modules/bin/playwright install-deps"
6+
},
47
"devDependencies": {
58
"@playwright/test": "^1.12.1",
69
"@types/jest": "^27.0.2",

0 commit comments

Comments
 (0)