Skip to content

Commit 91fdc7e

Browse files
committed
fixup!: remove typecheck step
1 parent 76168c9 commit 91fdc7e

File tree

2 files changed

+0
-44
lines changed

2 files changed

+0
-44
lines changed

.github/workflows/build.yaml

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -134,49 +134,6 @@ jobs:
134134
if: failure()
135135
uses: andymckay/[email protected]
136136

137-
typecheck:
138-
name: Check TypeScript types
139-
runs-on: ubuntu-latest
140-
timeout-minutes: 5
141-
steps:
142-
- name: Checkout repo
143-
uses: actions/checkout@v3
144-
145-
- name: Get changed files
146-
id: changed-files
147-
uses: tj-actions/[email protected]
148-
with:
149-
files: |
150-
src/**
151-
152-
- name: Install Node.js v16
153-
if: steps.changed-files.outputs.any_changed == 'true'
154-
uses: actions/setup-node@v3
155-
with:
156-
node-version: "16"
157-
158-
- name: Fetch dependencies from cache
159-
if: steps.changed-files.outputs.any_changed == 'true'
160-
id: cache-node-modules
161-
uses: actions/cache@v3
162-
with:
163-
path: "**/node_modules"
164-
key: yarn-build-${{ hashFiles('**yarn.lock') }}
165-
restore-keys: |
166-
yarn-build-
167-
168-
- name: Install dependencies
169-
if: steps.changed-files.outputs.any_changed == 'true' && steps.cache-node-modules.outputs.cache-hit != 'true'
170-
run: SKIP_SUBMODULE_DEPS=1 yarn --frozen-lockfile
171-
172-
- name: Run tsc on TypeScript files
173-
if: steps.changed-files.outputs.any_changed == 'true'
174-
run: yarn typecheck
175-
176-
- name: Fail workflow
177-
if: failure()
178-
uses: andymckay/[email protected]
179-
180137
build:
181138
name: Build
182139
runs-on: ubuntu-latest

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
"lint:scripts": "./ci/dev/lint-scripts.sh",
3131
"lint:ts": "eslint --max-warnings=0 --fix $(git ls-files '*.ts' '*.js' | grep -v 'lib/vscode')",
3232
"test": "echo 'Run yarn test:unit or yarn test:e2e' && exit 1",
33-
"typecheck": "tsc -p tsconfig.json --noEmit --skipLibCheck",
3433
"ci": "./ci/dev/ci.sh",
3534
"watch": "VSCODE_DEV=1 VSCODE_IPC_HOOK_CLI= NODE_OPTIONS='--max_old_space_size=32384 --trace-warnings' ts-node ./ci/dev/watch.ts",
3635
"icons": "./ci/dev/gen_icons.sh"

0 commit comments

Comments
 (0)