Skip to content

Commit 8e6c10e

Browse files
authored
Merge pull request #3263 from cdr/jsjoeio/fix-e2e-test
fix(testing): reduce flakiness of terminal.test.ts and use 1 worker for e2e tests
2 parents f5a3033 + 7309ea9 commit 8e6c10e

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

test/config.ts

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ const config: Config = {
5252
testDir: path.join(__dirname, "e2e"), // Search for tests in this directory.
5353
timeout: 60000, // Each test is given 60 seconds.
5454
retries: 3, // Retry failing tests 2 times
55+
workers: 1,
5556
}
5657

5758
if (process.env.CI) {

test/e2e/terminal.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ test.describe("Integrated Terminal", () => {
5050
await codeServer.focusTerminal()
5151

5252
await page.waitForLoadState("load")
53-
await page.keyboard.type(`echo '${testString}' > '${tmpFile}'`)
53+
await page.keyboard.type(`echo ${testString} > ${tmpFile}`)
5454
await page.keyboard.press("Enter")
5555
// It may take a second to process
5656
await page.waitForTimeout(1000)

yarn.lock

-5
Original file line numberDiff line numberDiff line change
@@ -3141,11 +3141,6 @@ eslint-plugin-import@^2.18.2:
31413141
resolve "^1.17.0"
31423142
tsconfig-paths "^3.9.0"
31433143

3144-
eslint-plugin-jest-playwright@^0.2.1:
3145-
version "0.2.1"
3146-
resolved "https://registry.yarnpkg.com/eslint-plugin-jest-playwright/-/eslint-plugin-jest-playwright-0.2.1.tgz#8778fee9d5915132a03d94370d3eea0a7ddd08f3"
3147-
integrity sha512-BicKUJUpVPsLbHN8c5hYaZn6pv8PCMjBGHXUfvlY1p75fh4APVfX2gTK14HuiR8/Bv3fKBQu5MTaqCro4E3OHg==
3148-
31493144
eslint-plugin-prettier@^3.1.0:
31503145
version "3.4.0"
31513146
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.4.0.tgz#cdbad3bf1dbd2b177e9825737fe63b476a08f0c7"

0 commit comments

Comments
 (0)