Skip to content

Commit 8d5d8da

Browse files
committed
i think i'm close
1 parent b1237f1 commit 8d5d8da

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

test/register.test.ts

+5-12
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ describe("register", () => {
2727
})
2828

2929
afterEach(() => {
30-
// jest.resetModules()
31-
// jest.resetAllMocks()
32-
// jest.clearAllMocks()
30+
jest.resetModules()
3331
})
3432

3533
afterAll(() => {
@@ -44,28 +42,23 @@ describe("register", () => {
4442
// expect spy to have been called
4543
expect(spy).toHaveBeenCalled()
4644
expect(spy).toHaveBeenCalledTimes(1)
45+
spy.mockClear()
4746
})
4847

4948
it("should log an error if something doesn't work", () => {
50-
mockRegisterFn.mockImplementation(() => console.log("frick ya"))
5149
loggerSpy = jest.spyOn(logger, "error")
5250
const message = "Can't find browser"
5351
const error = new Error(message)
54-
global.navigator.serviceWorker.register = () => {
55-
console.log("errror here")
56-
throw error
57-
}
58-
console.log(global.navigator.serviceWorker.register.toString())
59-
spy = jest.spyOn(global.navigator.serviceWorker, "register")
60-
spy.mockResolvedValue(() => {
52+
53+
mockRegisterFn.mockImplementation(() => {
6154
throw error
6255
})
6356

6457
// Load service worker like you would in the browser
6558
require("../src/browser/register")
6659

67-
expect(loggerSpy).toHaveBeenCalled()
6860
expect(spy).toHaveBeenCalled()
61+
expect(loggerSpy).toHaveBeenCalled()
6962
// expect(loggerSpy).toHaveBeenCalledTimes(1)
7063
// Because we use logError, it will log the prefix along with the error message
7164
// expect(loggerSpy).toHaveBeenCalledWith(`[Service Worker] registration: ${error.message} ${error.stack}`)

0 commit comments

Comments
 (0)