Skip to content

Commit 860c99e

Browse files
authored
Docs copyedits: README.md + CONTRIBUTING.md (#2242)
* Edit README * Edit CONTRIBUTING * Format CONTRIBUTING.MD * Incorporate feedback * Revert movement of CONTRIBUTING.MD and format
1 parent 7e1e9d1 commit 860c99e

File tree

2 files changed

+76
-91
lines changed

2 files changed

+76
-91
lines changed

README.md

+16-30
Original file line numberDiff line numberDiff line change
@@ -6,72 +6,58 @@ Run [VS Code](https://github.com/Microsoft/vscode) on any machine anywhere and a
66

77
## Highlights
88

9-
- **Code everywhere**
10-
- Code on your Chromebook, tablet, and laptop with a consistent development environment.
11-
- Develop on a Linux machine and pick up from any device with a web browser.
12-
- **Server-powered**
13-
- Take advantage of large cloud servers to speed up tests, compilations, downloads, and more.
14-
- Preserve battery life when you're on the go as all intensive tasks run on your server.
15-
- Make use of a spare computer you have lying around and turn it into a full development environment.
9+
- Code on any device with a consistent development environment
10+
- Use cloud servers to speed up tests, compilations, downloads, and more
11+
- Preserve battery life when you're on the go; all intensive tasks run on your server
1612

1713
## Getting Started
1814

19-
For a full setup and walkthrough, please see [./doc/guide.md](./doc/guide.md).
15+
There are two ways to get started:
2016

21-
### Quick Install
17+
1. Using the [install script](./install.sh), which automates most of the process. The script uses the system package manager (if possible)
18+
2. Manually installing code-server; see [Installation](./doc/install.md) for instructions applicable to most use cases
2219

23-
We have a [script](./install.sh) to install code-server for Linux, macOS and FreeBSD.
24-
25-
It tries to use the system package manager if possible.
26-
27-
First run to print out the install process:
20+
If you choose to use the install script, you can preview what occurs during the install process:
2821

2922
```bash
3023
curl -fsSL https://code-server.dev/install.sh | sh -s -- --dry-run
3124
```
3225

33-
Now to actually install:
26+
To install, run:
3427

3528
```bash
3629
curl -fsSL https://code-server.dev/install.sh | sh
3730
```
3831

39-
The install script will print out how to run and start using code-server.
40-
41-
### Manual Install
32+
When done, the install script prints out instructions for running and starting code-server.
4233

43-
Docs on the install script, manual installation and docker image are at [./doc/install.md](./doc/install.md).
34+
We also have an in-depth [setup and configuration](./doc/guide.md) guide.
4435

4536
### Alpha Program 🐣
4637

47-
We're working on a cloud platform to make deploying and managing code-server easier. If you don't want to worry about
38+
We're working on a cloud platform that makes deploying and managing code-server easier. Consider [joining our alpha program](https://codercom.typeform.com/to/U4IKyv0W) if you don't want to worry about
4839

4940
- TLS
5041
- Authentication
5142
- Port Forwarding
5243

53-
consider [joining our alpha program](https://codercom.typeform.com/to/U4IKyv0W).
54-
5544
## FAQ
5645

5746
See [./doc/FAQ.md](./doc/FAQ.md).
5847

59-
## Contributing
48+
## Want to help?
6049

61-
See [./doc/CONTRIBUTING.md](./doc/CONTRIBUTING.md).
50+
See [CONTRIBUTING](./doc/CONTRIBUTING.md) for details.
6251

6352
## Hiring
6453

65-
We ([@cdr](https://github.com/cdr)) are looking for engineers to help maintain
66-
code-server, innovate on open source and streamline dev workflows.
54+
We ([@cdr](https://github.com/cdr)) are looking for engineers to help [maintain
55+
code-server](https://jobs.lever.co/coder/e40becde-2cbd-4885-9029-e5c7b0a734b8), innovate on open source, and streamline dev workflows.
6756

6857
Our main office is in Austin, Texas. Remote is ok as long as
6958
you're in North America or Europe.
7059

71-
Please get in [touch](mailto:[email protected]) with your resume/github if interested.
72-
73-
We're also hiring someone specifically to help maintain code-server.
74-
See the listing [here](https://jobs.lever.co/coder/e40becde-2cbd-4885-9029-e5c7b0a734b8).
60+
Please get in [touch](mailto:[email protected]) with your resume/GitHub if interested.
7561

7662
## For Organizations
7763

doc/CONTRIBUTING.md

+60-61
Original file line numberDiff line numberDiff line change
@@ -8,42 +8,45 @@
88
- [Build](#build)
99
- [Structure](#structure)
1010
- [VS Code Patch](#vs-code-patch)
11+
- [Currently Known Issues](#currently-known-issues)
1112

1213
<!-- END doctoc generated TOC please keep comment here to allow auto update -->
1314

1415
- [Detailed CI and build process docs](../ci)
1516

1617
## Pull Requests
1718

18-
Please link to the issue each PR solves.
19-
If there is no existing issue, please first create one unless the fix is minor.
19+
Please create a [GitHub Issue](https://github.com/cdr/code-server/issues) for each issue
20+
you'd like to address unless the proposed fix is minor.
2021

21-
Please make sure the base of your PR is the master branch. We keep the GitHub
22-
default branch the latest release branch to avoid confusion as the
23-
documentation is on GitHub and we don't want users to see docs on unreleased
24-
features.
22+
In your Pull Requests (PR), link to the issue that the PR solves.
23+
24+
Please ensure that the base of your PR is the **master** branch. (Note: The default
25+
GitHub branch is the latest release branch, though you should point all of your changes to be merged into
26+
master).
2527

2628
## Requirements
2729

28-
Please refer to [VS Code's prerequisites](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites).
30+
The prerequisites for contributing to code-server are almost the same as those for
31+
[VS Code](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites).
32+
There are several differences, however. You must:
2933

30-
Differences:
34+
- Use Node.js version 12.x (or greater)
35+
- Have [nfpm](https://github.com/goreleaser/nfpm) (which is used to build `.deb` and `.rpm` packages and [jq](https://stedolan.github.io/jq/) (used to build code-server releases) installed
3136

32-
- We require a minimum of node v12 but later versions should work.
33-
- We use [nfpm](https://github.com/goreleaser/nfpm) to build `.deb` and `.rpm` packages.
34-
- We use [jq](https://stedolan.github.io/jq/) to build code-server releases.
35-
- The [CI container](../ci/images/debian10/Dockerfile) is a useful reference for all our dependencies.
37+
The [CI container](../ci/images/debian8/Dockerfile) is a useful reference for all
38+
of the dependencies code-server uses.
3639

3740
## Development Workflow
3841

3942
```shell
4043
yarn
4144
yarn vscode
4245
yarn watch
43-
# Visit http://localhost:8080 once the build completed.
46+
# Visit http://localhost:8080 once the build is completed.
4447
```
4548

46-
To develop inside of an isolated docker container:
49+
To develop inside an isolated Docker container:
4750

4851
```shell
4952
./ci/dev/image/run.sh yarn
@@ -53,35 +56,35 @@ To develop inside of an isolated docker container:
5356

5457
`yarn watch` will live reload changes to the source.
5558

56-
If changes are made to the patch and you've built previously you must manually
57-
reset VS Code then run `yarn vscode:patch`.
59+
If you introduce changes to the patch and you've previously built, you
60+
must (1) manually reset VS Code and (2) run `yarn vscode:patch`.
5861

5962
## Build
6063

61-
You can build with:
64+
You can build using:
6265

6366
```shell
6467
./ci/dev/image/run.sh ./ci/steps/release.sh
6568
```
6669

6770
Run your build with:
6871

69-
```
72+
```shell
7073
cd release
7174
yarn --production
7275
# Runs the built JavaScript with Node.
7376
node .
7477
```
7578

76-
Build release packages (make sure you run `./ci/steps/release.sh` first):
79+
Build the release packages (make sure that you run `./ci/steps/release.sh` first):
7780

78-
```
81+
```shell
7982
IMAGE=centos7 ./ci/dev/image/run.sh ./ci/steps/release-packages.sh
8083
# The standalone release is in ./release-standalone
8184
# .deb, .rpm and the standalone archive are in ./release-packages
8285
```
8386

84-
The `release.sh` script is the equivalent of:
87+
The `release.sh` script is equal to running:
8588

8689
```shell
8790
yarn
@@ -91,73 +94,69 @@ yarn build:vscode
9194
yarn release
9295
```
9396

94-
And `release-packages.sh` is:
97+
And `release-packages.sh` is equal to:
9598

96-
```
99+
```shell
97100
yarn release:standalone
98101
yarn test:standalone-release
99102
yarn package
100103
```
101104

102-
For a faster release build you can also run:
105+
For a faster release build, you can run instead:
103106

104-
```
107+
```shell
105108
KEEP_MODULES=1 ./ci/steps/release.sh
106109
node ./release
107110
```
108111

109112
## Structure
110113

111-
The `code-server` script serves an HTTP API to login and start a remote VS Code process.
114+
The `code-server` script serves an HTTP API for login and starting a remote VS Code process.
112115

113116
The CLI code is in [./src/node](./src/node) and the HTTP routes are implemented in
114117
[./src/node/app](./src/node/app).
115118

116-
Most of the meaty parts are in our VS Code patch which is described next.
119+
Most of the meaty parts are in the VS Code patch, which we described next.
117120

118121
### VS Code Patch
119122

120-
Back in v1 of code-server, we had an extensive patch of VS Code that split the codebase
121-
into a frontend and server. The frontend consisted of all UI code and the server ran
122-
the extensions and exposed an API to the frontend for file access and everything else
123-
that the UI needed.
123+
In v1 of code-server, we had a patch of VS Code that split the codebase into a front-end
124+
and a server. The front-end consisted of all UI code, while the server ran the extensions
125+
and exposed an API to the front-end for file access and all UI needs.
124126

125-
This worked but eventually Microsoft added support to VS Code to run it in the web.
126-
They have open sourced the frontend but have kept the server closed source.
127-
128-
So in interest of piggy backing off their work, v2 and beyond use the VS Code
129-
web frontend and fill in the server. This is contained in our
127+
Over time, Microsoft added support to VS Code to run it on the web. They have made
128+
the front-end open source, but not the server. As such, code-server v2 (and later) uses
129+
the VS Code front-end and implements the server. You can find this in
130130
[./ci/dev/vscode.patch](../ci/dev/vscode.patch) under the path `src/vs/server`.
131131

132132
Other notable changes in our patch include:
133133

134-
- Add our own build file which includes our code and VS Code's web code.
135-
- Allow multiple extension directories (both user and built-in).
136-
- Modify the loader, websocket, webview, service worker, and asset requests to
137-
use the URL of the page as a base (and TLS if necessary for the websocket).
138-
- Send client-side telemetry through the server.
139-
- Allow modification of the display language.
140-
- Make it possible for us to load code on the client.
141-
- Make extensions work in the browser.
142-
- Make it possible to install extensions of any kind.
143-
- Fix getting permanently disconnected when you sleep or hibernate for a while.
144-
- Add connection type to web socket query parameters.
145-
146-
Some known issues presently:
147-
148-
- Creating custom VS Code extensions and debugging them doesn't work.
149-
- Extension profiling and tips are currently disabled.
134+
- Adding our build file, which includes our code and VS Code's web code
135+
- Allowing multiple extension directories (both user and built-in)
136+
- Modifying the loader, websocket, webview, service worker, and asset requests to
137+
use the URL of the page as a base (and TLS, if necessary for the websocket)
138+
- Sending client-side telemetry through the server
139+
- Allowing modification of the display language
140+
- Making it possible for us to load code on the client
141+
- Making extensions work in the browser
142+
- Making it possible to install extensions of any kind
143+
- Fixing issue with getting disconnected when your machine sleeps or hibernates
144+
- Adding connection type to web socket query parameters
145+
146+
As the web portion of VS Code matures, we'll be able to shrink and possibly
147+
eliminate our patch. In the meantime, upgrading the VS Code version requires
148+
us to ensure that the patch is applied and works as intended. In the future,
149+
we'd like to run VS Code unit tests against our builds to ensure that features
150+
work as expected.
150151

151-
As the web portion of VS Code matures, we'll be able to shrink and maybe even entirely
152-
eliminate our patch. In the meantime, however, upgrading the VS Code version requires
153-
ensuring that the patch still applies and has the intended effects.
152+
To generate a new patch, run `yarn vscode:diff`
154153

155-
To generate a new patch run `yarn vscode:diff`.
154+
**Note**: We have [extension docs](../ci/README.md) on the CI and build system.
156155

157-
**note**: We have extension docs on the CI and build system at [./ci/README.md](../ci/README.md)
156+
If the functionality you're working on does NOT depend on code from VS Code, please
157+
move it out and into code-server.
158158

159-
If functionality doesn't depend on code from VS Code then it should be moved
160-
into code-server otherwise it should be in the patch.
159+
### Currently Known Issues
161160

162-
In the future we'd like to run VS Code unit tests against our builds to ensure features
163-
work as expected.
161+
- Creating custom VS Code extensions and debugging them doesn't work
162+
- Extension profiling and tips are currently disabled

0 commit comments

Comments
 (0)