refactor: waitforNavigation in logout test

Author: jsjoeio

test/e2e/logout.test.ts

@@ -46,9 +46,13 @@ describe("logout", () => {
 
     await page.hover(logoutButton)
 
-    await Promise.all([page.waitForNavigation(), page.click(logoutButton)])
-
-    const currentUrl = await page.url()
+    await page.click(logoutButton)
+    // it takes a second to navigate
+    // and since page.url comes back immediately
+    // we need this waitForNavigation, otherwise it will check
+    // before navigation has finished and fail
+    await page.waitForNavigation({ url: `${CODE_SERVER_ADDRESS}/login` })
+    const currentUrl = page.url()
     expect(currentUrl).toBe(`${CODE_SERVER_ADDRESS}/login`)
   })
 })