Skip to content

Commit 76c9603

Browse files
author
Akash Satheesan
committed
chore(ci): add other arches as a matrix
1 parent 78c3c97 commit 76c9603

File tree

1 file changed

+23
-17
lines changed

1 file changed

+23
-17
lines changed

.github/workflows/ci.yaml

+23-17
Original file line numberDiff line numberDiff line change
@@ -118,19 +118,22 @@ jobs:
118118
name: npm-package
119119
path: ./package.tar.gz
120120

121-
linux-amd64:
121+
# We use Ubuntu 16.04 here, so that our build is more compatible
122+
# with older libc versions. We used to (Q1'20) use CentOS 7 here,
123+
# but it has a full update EOL of Q4'20 and a 'critical security'
124+
# update EOL of 2024. We're dropping our full support 3 quarters
125+
# early, but this gets us CI speed benefits on GH.
126+
127+
# TODO: cache building yarn --production
128+
# possibly 2m30s of savings(?)
129+
# this requires refactoring our release scripts
130+
package:
122131
name: Linux x86-64 build
123132
needs: build
124-
125-
# We use Ubuntu 16.04 here, so that our build is more compatible
126-
# with older libc versions. We used to (Q1'20) use CentOS 7 here,
127-
# but it has a full update EOL of Q4'20 and a 'critical security'
128-
# update EOL of 2024. We're dropping our full support 3 quarters
129-
# early, but this gets us CI speed benefits on GH.
130-
131-
# TODO: cache building yarn --production
132-
# this requires refactoring our release scripts
133-
runs-on: ubuntu-16.04
133+
runs-on: ${{ matrix.os }}
134+
strategy:
135+
matrix:
136+
os: [ubuntu-16.04, ubuntu-arm64-16.04, macos-latest]
134137
steps:
135138
- uses: actions/checkout@v2
136139

@@ -152,11 +155,14 @@ jobs:
152155
- name: Decompress npm package
153156
run: tar -xzf package.tar.gz
154157

155-
- name: Build and test yarn package
156-
run: |
157-
yarn release:standalone
158-
yarn test:standalone-release
159-
yarn package
158+
- name: Build standalone release
159+
run: yarn release:standalone
160+
161+
- name: Sanity test standalone release
162+
run: yarn test:standalone-release
163+
164+
- name: Build packages with nfpm
165+
run: yarn package
160166

161167
- name: Upload release artifacts
162168
uses: actions/upload-artifact@v2
@@ -166,7 +172,7 @@ jobs:
166172

167173
test-e2e:
168174
name: End-to-end tests
169-
needs: linux-amd64
175+
needs: package
170176
runs-on: ubuntu-latest
171177
env:
172178
PASSWORD: e45432jklfdsab

0 commit comments

Comments
 (0)