Skip to content

Commit 752cca6

Browse files
committed
wip
1 parent 02f1c56 commit 752cca6

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

.github/workflows/npm-brew.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,15 @@ jobs:
2929
name: "npm-package"
3030
path: release-npm-package
3131

32+
# NOTE@jsjoeio - we need to make sure we're using
33+
# v7 or higher of the npm CLI because it's used
34+
# in the yarn publish:npm script in development builds
35+
# to modify package.json name.
36+
- name: Install Node & npm v8
37+
uses: actions/setup-node@v3
38+
with:
39+
node-version: "16.14.0"
40+
3241
- name: Publish npm package and tag with "latest"
3342
run: yarn publish:npm
3443
env:

ci/steps/publish-npm.sh

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,15 @@ main() {
5151
exit 1
5252
fi
5353

54+
# TODO@jsjoeio
55+
# Check that we're using at least v7 of npm CLI
56+
if ! command -v npm &> /dev/null; then
57+
echo "npm v7 or higher could not be found."
58+
echo "We use this to modify the package.json name for dev builds."
59+
echo "Please upgrade and re-run the script."
60+
exit 1
61+
fi
62+
5463
# This allows us to publish to npm in CI workflows
5564
if [[ ${CI-} ]]; then
5665
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
@@ -122,6 +131,7 @@ main() {
122131
fi
123132

124133
echo "using tag: $NPM_TAG"
134+
echo "using package name: $PACKAGE_NAME"
125135

126136
# We modify the version in the package.json
127137
# to be the current version + the PR number + commit SHA

0 commit comments

Comments
 (0)