Skip to content

Commit 73b55d0

Browse files
committed
Prevent builtin extensions from updating
1 parent a78f8b5 commit 73b55d0

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

patches/series

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ base-path.diff
33
proposed-api.diff
44
marketplace.diff
55
webview.diff
6+
update-builtin.diff
67
insecure-notification.diff
78
update-check.diff
89
logout.diff

patches/update-builtin.diff

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
Prevent builtin extensions from being updated
2+
3+
Updating builtin extensions from the marketplace prevents us from patching them
4+
(for example out GitHub authentication patches).
5+
6+
Index: code-server/lib/vscode/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
7+
===================================================================
8+
--- code-server.orig/lib/vscode/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
9+
+++ code-server/lib/vscode/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts
10+
@@ -1057,8 +1057,8 @@ export class ExtensionsWorkbenchService
11+
// Skip if check updates only for builtin extensions and current extension is not builtin.
12+
continue;
13+
}
14+
- if (installed.isBuiltin && !installed.local?.identifier.uuid) {
15+
- // Skip if the builtin extension does not have Marketplace id
16+
+ if (installed.isBuiltin) {
17+
+ // Never update builtin extensions.
18+
continue;
19+
}
20+
infos.push({ ...installed.identifier, preRelease: !!installed.local?.preRelease });

0 commit comments

Comments
 (0)