Skip to content

Commit 70edeb9

Browse files
committed
Set quality property in product configuration
When httpWebWorkerExtensionHostIframe.html is fetched it uses the web endpoint template (in which we do not include the commit) but if the quality is not set it prepends the commit to the web endpoint instead. The new static endpoint does not use/handle commits so this 404s. Long-term we might want to make the new static endpoint use commits like the old one but we will also need to update the various other static URLs to include the commit. For now I just fixed this by adding the quality since: 1. Probably faster than trying to find and update all static uses. 2. VS Code probably expects it anyway. 3. Gives us better control over the endpoint.
1 parent fd7f1ec commit 70edeb9

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ci/build/build-release.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ bundle_vscode() {
9090
{
9191
"enableTelemetry": true,
9292
"commit": "$(git rev-parse HEAD)",
93+
"quality": "stable",
9394
"date": $(jq -n 'now | todate')
9495
}
9596
EOF

0 commit comments

Comments
 (0)