Skip to content

Commit 703a502

Browse files
committed
fix(ci): temporarily disable install deps from cache
1 parent ecc06ea commit 703a502

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

.github/workflows/ci.yaml

+12-8
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,18 @@ jobs:
3131
- name: Install helm
3232
uses: azure/[email protected]
3333

34-
- name: Fetch dependencies from cache
35-
id: cache-yarn
36-
uses: actions/cache@v2
37-
with:
38-
path: "**/node_modules"
39-
key: yarn-build-${{ hashFiles('**/yarn.lock') }}
40-
restore-keys: |
41-
yarn-build-
34+
# NOTE@jsjoeio
35+
# disabling this until we can audit the build process
36+
# and the usefulness of this step
37+
# See: https://github.com/cdr/code-server/issues/4287
38+
# - name: Fetch dependencies from cache
39+
# id: cache-yarn
40+
# uses: actions/cache@v2
41+
# with:
42+
# path: "**/node_modules"
43+
# key: yarn-build-${{ hashFiles('**/yarn.lock') }}
44+
# restore-keys: |
45+
# yarn-build-
4246

4347
- name: Install dependencies
4448
# if: steps.cache-yarn.outputs.cache-hit != 'true'

src/node/cli.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,7 @@ function bindAddrFromAllSources(...argsConfig: Args[]): Addr {
662662
/**
663663
* Reads the socketPath based on path passed in.
664664
*
665-
* The one usually pased in is the DEFAULT_SOCKET_PATH.
665+
* The one usually passed in is the DEFAULT_SOCKET_PATH.
666666
*
667667
* If it can't read the path, it throws an error and returns undefined.
668668
*/

0 commit comments

Comments
 (0)