Skip to content

Commit 65ff47b

Browse files
committed
docs: update based on feedback
1 parent 5b4fb69 commit 65ff47b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

doc/CONTRIBUTING.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ and exposed an API to the front-end for file access and all UI needs.
121121

122122
Over time, Microsoft added support to VS Code to run it on the web. They have made
123123
the front-end open source, but not the server. As such, code-server v2 (and later) uses
124-
the VS Code front-end and implements the server. We use a git subtree to be able to pull in VS Code's front-end. This code lives under [./lib/vscode](./lib/vscode).
124+
the VS Code front-end and implements the server. We do this by using a git subtree to fork and modify VS Code. This code lives under [./lib/vscode](./lib/vscode).
125125

126-
Some noteworthy changes in our codebase:
126+
Some noteworthy changes in our version of VS Code:
127127

128128
- Adding our build file, which includes our code and VS Code's web code
129129
- Allowing multiple extension directories (both user and built-in)
@@ -138,8 +138,8 @@ Some noteworthy changes in our codebase:
138138
- Adding connection type to web socket query parameters
139139

140140
As the web portion of VS Code matures, we'll be able to shrink and possibly
141-
eliminate our patch. In the meantime, upgrading the VS Code version requires
142-
us to ensure that our changes are applied and work as intended. In the future,
141+
eliminate our modifications. In the meantime, upgrading the VS Code version requires
142+
us to ensure that our changes are still applied and work as intended. In the future,
143143
we'd like to run VS Code unit tests against our builds to ensure that features
144144
work as expected.
145145

0 commit comments

Comments
 (0)