Skip to content

Commit 64ba137

Browse files
committed
Replace console with logger in sw register
1 parent 959ff6c commit 64ba137

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

src/browser/register.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export async function registerServiceWorker(): Promise<void> {
1414
await navigator.serviceWorker.register(path, {
1515
scope: options.base + "/",
1616
})
17-
console.log("[Service Worker] registered")
17+
logger.info(`[Service Worker] registered`)
1818
} catch (error) {
1919
logError(logger, `[Service Worker] registration`, error)
2020
}
@@ -23,5 +23,5 @@ export async function registerServiceWorker(): Promise<void> {
2323
if (typeof navigator !== "undefined" && "serviceWorker" in navigator) {
2424
registerServiceWorker()
2525
} else {
26-
console.error(`[Service Worker] navigator is undefined`)
26+
logger.error(`[Service Worker] navigator is undefined`)
2727
}

test/unit/register.test.ts

+9-7
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ describe("register", () => {
2222
})
2323

2424
beforeEach(() => {
25+
jest.clearAllMocks()
2526
jest.mock("@coder/logger", () => loggerModule)
2627
})
2728

@@ -39,6 +40,7 @@ describe("register", () => {
3940
global.navigator = (undefined as unknown) as Navigator & typeof globalThis
4041
global.location = (undefined as unknown) as Location & typeof globalThis
4142
})
43+
4244
it("test should have access to browser globals from beforeAll", () => {
4345
expect(typeof global.window).not.toBeFalsy()
4446
expect(typeof global.document).not.toBeFalsy()
@@ -74,24 +76,24 @@ describe("register", () => {
7476
})
7577

7678
describe("when navigator and serviceWorker are NOT defined", () => {
77-
let spy: jest.SpyInstance
78-
7979
beforeEach(() => {
80-
spy = jest.spyOn(console, "error")
80+
jest.clearAllMocks()
81+
jest.mock("@coder/logger", () => loggerModule)
8182
})
8283

8384
afterAll(() => {
8485
jest.restoreAllMocks()
8586
})
8687

87-
it("should log an error to the console", () => {
88+
it("should log an error", () => {
8889
// Load service worker like you would in the browser
8990
require("../../src/browser/register")
90-
expect(spy).toHaveBeenCalled()
91-
expect(spy).toHaveBeenCalledTimes(1)
92-
expect(spy).toHaveBeenCalledWith("[Service Worker] navigator is undefined")
91+
expect(loggerModule.logger.error).toHaveBeenCalled()
92+
expect(loggerModule.logger.error).toHaveBeenCalledTimes(1)
93+
expect(loggerModule.logger.error).toHaveBeenCalledWith("[Service Worker] navigator is undefined")
9394
})
9495
})
96+
9597
describe("registerServiceWorker", () => {
9698
let serviceWorkerPath: string
9799
let serviceWorkerScope: string

0 commit comments

Comments
 (0)