Fix fs.exists

code-asher · code-asher · commit 6274f176792b · 2019-03-27T14:27:24.000-05:00
callbackify seems to always adds an error as the first argument. Opted
to just use the promise for this one.
diff --git a/packages/protocol/src/browser/modules/fs.ts b/packages/protocol/src/browser/modules/fs.ts
@@ -98,9 +98,7 @@ export class FsModule {
 	}
 
 	public exists = (path: fs.PathLike, callback: (exists: boolean) => void): void => {
-		callbackify(this.proxy.exists)(path, (exists) => {
-			callback!(exists as any);
-		});
+		this.proxy.exists(path).then((exists) => callback(exists)).catch(() => callback(false));
 	}
 
 	public fchmod = (fd: number, mode: string | number, callback: (err: NodeJS.ErrnoException) => void): void => {

Original file line number	Diff line number	Diff line change
`@@ -98,9 +98,7 @@ export class FsModule {`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`public exists = (path: fs.PathLike, callback: (exists: boolean) => void): void => {`
`101`		`- callbackify(this.proxy.exists)(path, (exists) => {`
`102`		`- callback!(exists as any);`
`103`		`- });`
	`101`	`+ this.proxy.exists(path).then((exists) => callback(exists)).catch(() => callback(false));`
`104`	`102`	`}`
`105`	`103`
`106`	`104`	`public fchmod = (fd: number, mode: string \| number, callback: (err: NodeJS.ErrnoException) => void): void => {`