Catch all localhost duplicates when forwarding a port (#112575)

alexr00 · web-flow · commit 608dfc136341 · 2020-12-16T15:10:15.000+01:00
Fixes #112571
diff --git a/src/vs/workbench/services/remote/common/remoteExplorerService.ts b/src/vs/workbench/services/remote/common/remoteExplorerService.ts
@@ -96,7 +96,7 @@ export function mapHasAddressLocalhostOrAllInterfaces<T>(map: Map<string, T>, ho
 	if (originalAddress) {
 		return originalAddress;
 	}
-	const otherHost = isAllInterfaces(host) ? 'localhost' : (host === 'localhost' ? '0.0.0.0' : undefined);
+	const otherHost = isAllInterfaces(host) ? 'localhost' : (isLocalhost(host) ? '0.0.0.0' : undefined);
 	if (otherHost) {
 		return mapHasAddress(map, otherHost, port);
 	}

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ export function mapHasAddressLocalhostOrAllInterfaces<T>(map: Map<string, T>, ho`
`96`	`96`	`if (originalAddress) {`
`97`	`97`	`return originalAddress;`
`98`	`98`	`}`
`99`		`- const otherHost = isAllInterfaces(host) ? 'localhost' : (host === 'localhost' ? '0.0.0.0' : undefined);`
	`99`	`+ const otherHost = isAllInterfaces(host) ? 'localhost' : (isLocalhost(host) ? '0.0.0.0' : undefined);`
`100`	`100`	`if (otherHost) {`
`101`	`101`	`return mapHasAddress(map, otherHost, port);`
`102`	`102`	`}`