Skip to content

Commit 604491d

Browse files
authored
fix: use correct command to Open Folder on Welcome page (#3437)
* chore: update CHANGELOG * fix: use openFolder in welcomePage In 1.56.2, they modified the WelcomePage use of OpenFileFolder in src/vs/workbench/contrib/debug/browser/welcomeView.ts to only use on macOS + Desktop (i.e. not Web). This caused the "Open Folder" to not work on macOS + macOS-like environments. Instead, we use OpenFolder which is a registered command and works as expected.
1 parent ac96517 commit 604491d

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ VS Code v1.56.1
7171
- fix: Check the logged user instead of $USER #3330 @videlanicolas
7272
- fix: Fix broken node_modules.asar symlink in npm package #3355 @code-asher
7373
- fix: Update cloud agent to fix version issue #3342 @oxy
74+
- fix: use correct command to Open Folder on Welcome page #3437 @jsjoeio
7475

7576
### Documentation
7677

lib/vscode/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default () => `
2020
<h2 class="caption">${escape(localize('welcomePage.start', "Start"))}</h2>
2121
<ul>
2222
<li><a href="command:workbench.action.files.newUntitledFile">${escape(localize('welcomePage.newFile', "New file"))}</a></li>
23-
<li class="mac-only"><a href="command:workbench.action.files.openFileFolder">${escape(localize('welcomePage.openFolder', "Open folder..."))}</a> or <a href="command:git.clone">${escape(localize('welcomePage.gitClone', "clone repository..."))}</a></li>
23+
<li class="mac-only"><a href="command:workbench.action.files.openFolder">${escape(localize('welcomePage.openFolder', "Open folder..."))}</a> or <a href="command:git.clone">${escape(localize('welcomePage.gitClone', "clone repository..."))}</a></li>
2424
<li class="windows-only linux-only"><a href="command:workbench.action.files.openFolder">${escape(localize('welcomePage.openFolder', "Open folder..."))}</a> or <a href="command:git.clone">${escape(localize('welcomePage.gitClone', "clone repository..."))}</a></li>
2525
</ul>
2626
</div>

0 commit comments

Comments
 (0)